Added getParcelDocument for the /parcels/{id}/documents/{type} endpoint #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villermen
approved these changes
Feb 6, 2024
Comment on lines
+461
to
+463
| * Fetches a single parcel document based on requested document type, content type, and dpi. | ||
| * | ||
| * If the parcel hasn't had its labels created through {@see self::createLabel()} it will result in an exception. |
Comment on lines
+491
to
+492
| RequestOptions::QUERY => ['dpi' => $dpi], | ||
| RequestOptions::HEADERS => ['Accept' => $contentType], |
There was a problem hiding this comment.
Wasn't aware of these constants. I'll make a mental note to use these for the other calls too when this is merged!
Co-authored-by: Sjoerd Nuijten <villermen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some basic validation of the request parameters based on the Sendcloud API documentation and added a few tests to verify these scenarios. I wasn't sure about codestyle and function imports so based my changes off existing code.
Closes #31