Fixes of service points integration #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villermen
reviewed
Feb 6, 2024
|
@AlexisPPLIN I've split the services as per your suggestion and updated the documentation to match. Can you check if I've missed anything? I've already verified this to work on production to be safe. |
|
@villermen I've not tested this in production but LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy new year !
I recently started using my service point contribution from
v5.1.0, and I realized that everything was broken 🤕So here is my patch:
Solves
servicepoints.sendcloud.scURL instead of the standardparcel.sendcloud.sc. So I added a new constantSERVICE_POINTS_BASE_URL.service-point->service-points.distanceoptional (null) because only returned by the api iflatitudeandlongitudeare provided.Additions
Have a nice day 👋