Add wrappers for new Admin API Endpoints #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial README.rst
Correct formatting issues and simplify text.
Add examples and documentation sections and misc edits.
Delete old README.md and point setup.py to new README.rst
Create new ‘docs’ directory. Run sphinx-quickstart in ‘docs’
Begin organizing .gitignore to identify used and unused entries.
Create initial index.rst and the the User-API documentation.
Rename and refactor helper.py to utils.py to make naming more consistent with established practices.
The session attribute in an API object should not be ‘public’, and therefore should be prefixed by an ‘_’. Update API classes’ method docstrings to eliminate warnings and enable proper auto-documentation by Sphinx autodoc extension.
The ‘pep440-post’ style better reflects post-release commits, and enables building of installable dev-builds with sortable version numbers. Additionally, going forward, the package release tags will incorporate a release status flag (a - alpha, b - beta, rc - release candidate) in the format: major.minor[flag]micro
Update docstrings and User API Doc for the main package __init__.py module.
This copyright reference shows up in the footers of the HTML docs generated by Sphinx.
The Quickstart guide / tutorial is now finished!!!
Report and needed corrections provided by @DJF3 -Thank you!
# Conflicts: # README.rst # docs/conf.py # docs/user/intro.rst
# Conflicts: # README.rst
Add a ACCESS_TOKEN_ENVIRONEMENT_VARIABLE package-level constant that specifies the name of the environment variable that is referenced by the package to retrieve a user’s Spark access token from the environment.
Create the pytest tests-package structure, initial Rooms tests and supporting fixtures.
Complete the test suite for the RoomsAPI class.
The RoomsAPI.update() method should be sending a PUT request (not a POST).
Verb should be PUT instead of POST
Add people.create() and people.update() methods to wrap the new people admin API endpoints. Update the Person properties to reflect new person object attributes. Add property docstrings and have properties return `None` if not present.
Add a wrapper for the new Organizations API endpoints.
Add a wrapper for the new Licenses API endpoints.
Add a wrapper for the new Roles API endpoints.
Add the new Organizations, Licenses and Roles API wrappers to the CiscoSparkAPI class.
Verb should be PUT instead of POST
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20 Added wrappers for new Admin API Endpoints
Squashed some Bugs:
#30 team_memberships.update() was using the wrong HTTP verb
memberships.update() was also using the wrong HTTP verb