-
Notifications
You must be signed in to change notification settings - Fork 153
webexteamssdk Ready for Release! 🤞 #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Pipfile.lock for secure package management; rebuilding for new webexteamsdk.
Create a `script/` directory to contain scripts for common developer workflow scripts, and remove the project's Makefile. Include a `script/README.md` with information on the workflow scripts.
Add IPython (used for the project's interactive console) to the project's development dependencies.
Rename the `ciscosparkapi` package to `webexteamsdk`.
Move the WebexTeamsAPI class to the new .api sub-package. Move all package defaults / internal static configurations to the config.py module. Move all environment variable usage to the environment.py file.
Remove the deprecated `timeout` references. Clean names and object references.
Remove file-level meta data and add the license and copyright header.
Rebrand `Cisco Spark` to `Webex Teams`.
The default models have never permitted their properties to be updated. Let's go ahead and make them immutable.
Last (?) project name change.
Reafactor the existing Ïtest suite to include the name and package structure changes.
Ignore .pytest_cache files.
More Spark to Webex Teams name changes.
Add testing on Python v3.7. Use the `script/ci` script for CI builds. Temporarily disable the CI script setup and build steps.
Ensure pipenv is installed, then run the setup script as part of the `script/ci` script.
Great catches and fixes by @UniversalSuperBox. Pull them into the webexteamssdk package.
Add descriptions of ignored items and exclude non-code directories.
Update the example code with Cisco Spark to Webex Teams name changes, copyright and license headers, and PEP8 fixes.
- Spark to Webex Teams name changes. - Remove unnecessary helper functions. - Remove unnecessary classes. - Add license headers.
The Licenses, Organizations, and Roles APIs do not support pagination. Remove pagination references and the `max=` argument from their `list()` methods.
Do not run rate-limit tests by default
- Change Spark references to Webex Teams - Change location and instructions for obtaining a Personal Access Token - Simplify the methods-list table in the Quickstart - Add MalformedResponse and RateLimitWarning to the top-level package interface - Change autodoc_default_flags (deprecated) to autodoc_default_options
- Move the contributing docs to the `docs/` directory - Convert the Code of Conduct to reStructuredText - Convert Contributing to reStructuredText and update the document - Add the contributing docs to the on-line documentation
Don't use `--` prefixes for selecting the tests to be executed. Add an option to exeute the rate-limit tests.
Spark to Webex Teams name changes, updates to the contributor documents, and etc.
Dates and times returned by Webex Teams should be modeled using Python's native datetime class - or a derivative thereof. :)
Include info on the ciscosparapi to webexteamssdk migration.
A few final changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.