Since 2.4.0 I can no longer search for emails earlier than ~2 years

[vesper8]

I've been testing my program by fetching emails since the last 3 years. I noticed a sudden huge drop in emails being returned since updating to 2.4.0

To test that this isn't related to something else, I just downgraded webklex/php-imap and forced it to be 2.3.0 and the problem went away

On 2.3.0

php artisan mail:check 'Some String' '5 year'
Checking for new bookings from Some String since 2016-01-06 in all folders
Found 422 messages matching criteria since 2016-01-06

On 2.4.0

php artisan mail:check 'Some String' '5 year'
Checking for new bookings from Some String since 2016-01-06 in all folders
Found 58 messages matching criteria since 2016-01-06

I can provide more info if necessary

[Webklex]

Hi @vesper8 ,
thanks for your report.

Looks like I screwed up, or I'm confused right now:

php-imap/src/Query/Query.php

Line 225 in 356432e

$message_key = ClientManager::get('options.message_key');

..gets overwritten here:

php-imap/src/Query/Query.php

Lines 243 to 257 in 356432e

	switch ($message_key){
	case 'number':
	$message_key = $message->getMessageNo();
	break;
	case 'list':
	$message_key = $msglist;
	break;
	case 'uid':
	$message_key = $message->getUid();
	break;
	default:
	$message_key = $message->getMessageId();
	break;
	}

..which leads to $message_key being overwritten. Imagine you have several emails without message id; well they will get overwritten..

Best regards,

[vesper8]

Sounds like you're on to something.. let me know if you want me to test anything. Currently this is a show-stopper so I'm hoping you can release a hot fix soon

[Webklex]

I can imagine.
Hotfix has been applied: https://github.com/Webklex/php-imap/releases/tag/2.4.1

Best regards,

[vesper8]

Super! I can confirm it is back to working like before. Thanks for the quick work!