Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templates markup in repository browser URL #11669

Closed
nijel opened this issue May 20, 2024 · 2 comments · Fixed by #11670
Closed

Templates markup in repository browser URL #11669

nijel opened this issue May 20, 2024 · 2 comments · Fixed by #11670
Assignees
@nijel
Labels
bug Something is broken.
Milestone
5.6

Comments

@nijel
Copy link
Member

nijel commented May 20, 2024

Is it possible to use templates markup other than {{ branch }}, {{ filename }} and {{ line }} ?

The Repository browser doc mentions the Template markup doc, which lists {{ component_name }} among other templates. I don't see documented an explicit restriction of what templates can be used in repository browser, but I'm trying to use {{ component_name }} and I'm getting "Enter a valid URL." error message instead.

Originally posted by @rffontenelle in #11662
@nijel nijel added the bug Something is broken. label May 20, 2024
@nijel nijel added this to the 5.6 milestone May 20, 2024
@nijel nijel self-assigned this May 20, 2024
nijel added a commit to nijel/weblate that referenced this issue May 20, 2024
@nijel
fix(component): allow markup in repository browser URL
23882df 
Base it on char field instead of URL to get rid of default validation.

Fixes WeblateOrg#11669
@nijel nijel mentioned this issue May 20, 2024
Merged
5 tasks
nijel added a commit to nijel/weblate that referenced this issue May 20, 2024
@nijel
fix(component): allow markup in repository browser URL
b411b51 
Base it on char field instead of URL to get rid of default validation.

Fixes WeblateOrg#11669
nijel added a commit to nijel/weblate that referenced this issue May 20, 2024
@nijel
fix(component): allow markup in repository browser URL
3a5444a 
Base it on char field instead of URL to get rid of default validation.

Fixes WeblateOrg#11669
@nijel nijel closed this as completed in 9ff8953 May 20, 2024
@github-actions GitHub Actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

1 similar comment
@github-actions GitHub Actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nijel nijel

Labels
bug Something is broken.
Projects
None yet
Milestone
5.6
Development

Successfully merging a pull request may close this issue.

fix(component): allow markup in repository browser URL nijel/weblate
1 participant
@nijel