Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary translation explanation mapping is broken #9476

Closed
2 tasks done
pavelhoral opened this issue Jun 28, 2023 · 5 comments · Fixed by #9485
Closed
2 tasks done

Glossary translation explanation mapping is broken #9476

pavelhoral opened this issue Jun 28, 2023 · 5 comments · Fixed by #9485
Assignees
Labels
bug Something is broken. translate-toolkit Issues which need to be fixed in the translate-toolkit
Milestone

Comments

@pavelhoral
Copy link

pavelhoral commented Jun 28, 2023

Describe the issue

We are using TBX glossary and there is a bug when the TBX gets updated and Weblate pulls changes from the repo.

When we add new glossary entry in Weblate, the explanation is written as <descrip> for source unit explanation and as <note from="translator"> for target unit explanation.

However when we modify TBX in the VCS and pull the changes, everything from the TBX file gets mapped to note column in the database. So we end up with duplicate explanations that can not be deleted via UI.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

  1. Create new translation project
  2. Create glossary component
  3. Add new glossary entry with source string explanation
  4. Push to repository
  5. Make new commit in the repository by changing glossary translation
  6. Pull changes to Weblate (update from repo)
  7. Observe duplicate explanation that can no longer be edited

Expected behavior

Source string explanation and translation explanation should be mapped to explanation only and note should no longer be used.

Screenshots

obrazek

Exception traceback

No response

How do you run Weblate?

Docker container

Weblate versions

4.18.1

Weblate deploy checks

No response

Additional context

No response

@nijel nijel added bug Something is broken. translate-toolkit Issues which need to be fixed in the translate-toolkit labels Jun 29, 2023
@github-actions
Copy link

The issue you've reported needs to be addressed in the translate-toolkit. Please file the issue there, and include links to any relevant specifications about the formats (if applicable).

@nijel
Copy link
Member

nijel commented Jun 29, 2023

Ah, translate-toolkit sets the from attribute note when saving this, but does no filtering when reading. Needs to be fixed there.

@pavelhoral
Copy link
Author

Ah, translate-toolkit sets the from attribute note when saving this, but does no filtering when reading. Needs to be fixed there.

Should I create the issue there? I am not sure I understand the cause you've described.

@nijel nijel self-assigned this Jun 30, 2023
nijel added a commit to nijel/weblate that referenced this issue Jun 30, 2023
@nijel nijel added this to the 4.18.2 milestone Jun 30, 2023
nijel added a commit to nijel/translate that referenced this issue Jun 30, 2023
This makes it consisted with adding.

See WeblateOrg/weblate#9476
nijel added a commit to nijel/translate that referenced this issue Jun 30, 2023
This makes it consistent with adding.

See WeblateOrg/weblate#9476
@nijel
Copy link
Member

nijel commented Jun 30, 2023

Should be fixed by translate/translate#4955 and #9485

nijel added a commit to translate/translate that referenced this issue Jun 30, 2023
This makes it consistent with adding.

See WeblateOrg/weblate#9476
nijel added a commit that referenced this issue Jun 30, 2023
@github-actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

nijel added a commit that referenced this issue Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken. translate-toolkit Issues which need to be fixed in the translate-toolkit
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants