Skip to content

Conversation

krystalwon
Copy link

No description provided.

Copy link

@mjumbewu mjumbewu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice-looking dashboard. A few suggestions below, and a few more in-line with your code.

  • suggestion: You should move all your files to the root folder. This would make it easier to share your dashboard if you enable GitHub Pages (which you should do). Also related to GitHub Pages, you should try to keep spaces out of folder and file names; some web servers have trouble dealing with them.
  • idea: It would be cool to be able to click within a state to select it in addition to having states be selectable from your select element

Also a couple a11y issues I saw using the Axe developer tools:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: This file is over 2 megabytes. That's not too egregious, but in this case it seems unnecessarily large. For any data asset over maybe half a megabyte that's going to by downloaded by the user's browser, I would consider whether it's necessary for the file to be so large. Sometimes it is necessary for files large (e.g., your cleaned workforce CSV is probably not going to get any smaller without splitting it up), but in the case of these boundary shapes, you can likely get away with simplifying the polygons a lot without losing anything, because the states are shown at such a low zoom level.

Comment on lines +129 to +132
<div id="about-section">
<div id="project-description">
<h2>About This Project</h2>
<p>This dashboard project, developed as part of MUSA 6110 at the University of Pennsylvania, explores workforce training providers across the United States.</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Nice; I like this about section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants