-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HuskSync 2.0 - no more proxy plugin, redis caching, rewritten database handling, remove sqlite support #33
Conversation
Use redis key caching, remove need for proxy plugin Make platform independent to allow porting to other platforms
Disconnecting from the proxy is a good solution. |
…ion, better exception handling
Too fast.... |
# Conflicts: # bukkit/src/main/java/net/william278/husksync/bukkit/util/PlayerSetter.java # common/src/main/java/net/william278/husksync/proxy/data/DataManager.java # gradle.properties
My initial checklist is now done, but still todo before merge & release:
Worth noting, I wrote a little library to aid 1.4 --> 2.0 importing (https://github.com/WiIIiam278/HSLDataConverter). I've decided that data importing wont be manual, as adding stuff to the plugin enable logic is liable to go wrong. Update (Jul 10, 2022): Moved checklist to original post. |
common/src/main/java/net/william278/husksync/listener/EventListener.java
Outdated
Show resolved
Hide resolved
…sion checker fixes, fix TAB completion in console
… for better compatibility
Merging this now to begin final checks and polish. |
I thought about it and decided it was time for a change of approach. The goal of this rewrite is basically to deprecate the need for a proxy plugin while maintaining the speed afforded by redis, and also opening the door to more platforms (fabric). It'll do this through utilizing redis key caching and a rewrite of the common module.
implements Serializable
(this is a big improvement for many reasons). Should also improve database performance/inventory
and/enderchest
commandThe work done for HuskSync 1.4 with regard to removing the MPDB dependence will still be very useful for this.
Unfortunately, that means SQLite support will be dropped, though this isn't really an issue. Nobody running HuskSync doesn't have a MySQL database. Further work to support additional database types can be explored.
A side effect of all this work, particularly on serialization, is that there should be decent performance gains, especially on expensive events (#31)
Thoughts and feedback welcome.