Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS number, percent and angle parsing #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RoBorg
Copy link

@RoBorg RoBorg commented Jan 25, 2020

Should close #11

@WickyNilliams
Copy link
Owner

Thanks for this. Am I right in thinking that these formats are new to css colors level 4? I had not come across most of these! I'm struggling after a quick search to find any info online about browser support for these.

The hue value only supporting [0, 360] is a great catch, can't believe I missed that.

@RoBorg
Copy link
Author

RoBorg commented Jan 25, 2020

As far as I can tell they're all from level 3... looks like 4 introduces a load of new stuff that this won't parse :(

@RoBorg
Copy link
Author

RoBorg commented Jan 25, 2020

I used the docs here: https://developer.mozilla.org/en-US/docs/Web/CSS/color & https://developer.mozilla.org/en-US/docs/Web/CSS/color_value

@WickyNilliams
Copy link
Owner

I had a quick look through the v3 spec and it doesn't mention rad or turn units etc. I'll have a proper look at this next week and report back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS Not Parsed Correctly
3 participants