Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote title to get correct file description #451

Merged
merged 2 commits into from
May 29, 2023
Merged

Conversation

yzqzss
Copy link
Contributor

@yzqzss yzqzss commented Jan 14, 2023

Fix empty .desc files caused by special characters such as = or & in the title.

See also: mediawiki-client-tools#75

@yzqzss yzqzss changed the title Quote title to get correct page Quote title to get correct file description Jan 14, 2023
@nemobis
Copy link
Member

nemobis commented May 29, 2023

Thanks!

@nemobis nemobis merged commit 8167987 into WikiTeam:master May 29, 2023
@Pokechu22
Copy link
Contributor

This causes issues for me due to urllib.parse not existing - based on https://stackoverflow.com/q/29358403 it seems like this is a python 3 thing. I'm not sure what the python2 alternative is (urlparse doesn't have a quote function).

@Pokechu22
Copy link
Contributor

Ah, whoops, that was already fixed in #466.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants