Shippensburg Land Projections: Add to Land Cover Modification Dialog

[rajadain]

Overview

Adds a dropdown to the Land Cover Modification Dialog to auto-populate the fields with values from the selected Land Cover analysis results. This takes advantage of the current implementation, with minor edits to populate the values and remember which preset was used.

The connecting issue mentions two implementation details that are deferred for later:

• Using the preset values to populate the gray "auto values" rather than the black "user values"
  • This layered modification will likely require something akin to the ring approach, which was too complex to implement here
• Having these values affect other modifications, such as conservation practices
  • These are known drawbacks of the current implementation (see Manual Entry: Update Modifications on Land Use Change #3158 and Manual Entry: Land Cover Changes Should Affect Entire MapShed Dictionary #3159), and would be too complex to implement here

Connects #3333

Demo

Notes

Instead of adding another endpoint to fetch the values from the Drexel API again, I chose to reuse the values already fetched during analysis. This creates a new dependency on Analyze results, saves a lot of code.

The area total for the DRB numbers does not match exactly (because the NLCD numbers come from our own geoprocessing service and the DRB numbers from from Drexel's fast zonal API). I could not come up with a way to resolve this discrepancy, and is left to the user to manage.

Once you save Land Cover modifications, wait for the results to save, and refresh the page, it calculates the results again. This is existing behavior, logged in #3343.

The code for getting the appropriately modified GMS for a scenario is currently spread across many functions, and needs to be unified. I'll make a follow up enhancement card for that.

Testing Instructions

• Check out this PR and bundle
• Go to :8000/ and select a shape within the DRB
• Create a Mapshed project with it. Add changes to the area.
• Open the Land Cover Modification dialog
  • Ensure you see a preset dropdown at the top
• Select a preset
  • Ensure values are appropriately filled out for the preset, and that the total is updated
• Ensure the total matches, then click "Save"
  • Ensure the scenario results are recalculated with the new updates
• Open the Land Cover Modification dialog again
  • Ensure the land cover edits are persisted
  • Ensure the preset selects the right dropdown
• Select the default preset
  • Ensure all fields are emptied
• Save and open the Land Cover Modification dialog again
  • Ensure the scenario results are recalculated with the new updates
  • Ensure the land cover edits are persisted
  • Ensure the preset selects the right dropdown

[mmcfarland]

Looks great. The non-matching sum when switching between land cover sources is a bummer, but any "fix" would have to be arbitrary, so I think leaving it is appropriate. I could expect some feedback from the client about giving it a particular behavior though. I tested through a number of scenarios, including switching unit preferences mid-way, and it always showed up correctly.

I was able to get in a sequence of the app not thinking I was in the DRB on some large hand drawn shapes in SE PA (and disabling the dropdown), but I couldn't reliably reproduce it after a while. I may have clipped the DRB boundary without realizing it. If it crops up for you at all, it may be worth looking into further. Future issues look good too. 👍

[rajadain]

Thanks for taking a look! I added #3345 to add the DRB test polygon as a visualizable layer, to help debug this both for us and the users, since there is now much DRB-specific stuff in the app.

[rajadain]

Created #3346, #3347, and #3348 for further work along these lines.