Skip to content

Conversation

cschucode
Copy link

No description provided.

@cschucode cschucode requested a review from vforge as a code owner February 26, 2020 22:08
package.json Outdated
{
"name": "@wikia/react-common",
"version": "11.1.0",
"version": "11.2.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this; this is updated automatically when releasing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It snuck in there. I removed. You reviewed to quickly. 😄

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Copy link
Collaborator

@vforge vforge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change package.json's version manually

@cschucode cschucode merged commit b5c24d1 into master Feb 26, 2020
@cschucode cschucode deleted the add-prop-type branch February 26, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants