Skip to content

Conversation

vforge
Copy link
Collaborator

@vforge vforge commented Jan 21, 2019

  • Tweak SVG loader
  • New icons in all 3 sizes
  • Added default size prop for all the icons
  • Moved existing icons to legacy-icons/Legacy<ICONNAME>
  • Make sure all the SVGs are correct

This is is huge - mostly because all the new icons that were added.

Summary of changes:

  • Moved current DS icons to legacy-icons/LegacyIcon<Name>
    • Adjusted Components that are using current icons so they're using legacy ones
  • Added new icons in all sizes to icons/Icon<Name><Size>
    • imported all SVG files
    • created new build process that's converting all the SVGs into components, adding tests and generating new demo page for components
    • new components have standarized names - Icon<Name>, Icon<Name>Small, Icon<Name>Tiny
    • new components are passing all the props and by default have only one prop - size which is changing the width and height of the SVG icon
    • new icons have their fill defaulted to currentColor
    • new icons are based on styled-components which is allowing to resize them dynamically and also is removing the obsolete CSS

Preview: http://localhost:6060/#!/Icons
Demo movie:
https://giphy.com/embed/1gQtwNUdZDwx3JvKSk

@vforge vforge added the wip Work in progress label Jan 21, 2019
@vforge vforge removed the wip Work in progress label Jan 23, 2019
@vforge
Copy link
Collaborator Author

vforge commented Feb 21, 2019

Went with #39 instead

@vforge vforge closed this Feb 21, 2019
xkxd added a commit that referenced this pull request Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant