Add missing tests for nav + cleanup #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsutterfield
reviewed
Mar 4, 2019
| } | ||
| }; | ||
|
|
||
| const onMouseWheel = (event) => { |
There was a problem hiding this comment.
Do we not need this handler anymore?
There was a problem hiding this comment.
probably not.
mousewheelandDOMMouseScrollare non-standard => MDN suggests usingwheelinstead- they were used to differently (don't know why) support mouse scrolling but it's already covered via
scrollevent. I've tried to reverse-engineer this code but didn't find any specific reasons to use it, so considering our current tech stack and moderns browsers I decided to remove it until we find some good reason to bring it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Wikia/iwing
change base to IW-1022 before merging