Skip to content

Advanced Image View #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 27, 2019
Merged

Advanced Image View #56

merged 16 commits into from
Mar 27, 2019

Conversation

JoshuaRogan
Copy link
Contributor

@JoshuaRogan JoshuaRogan commented Mar 19, 2019 •
edited by vforge
Loading

@JoshuaRogan

  • Migrate image view from Fandom creator

@vforge

  • Create utils/vignette - a Vignette helper, add it to the styleguide with a readme file. This should replace all usages of vignette-js in client apps.
  • Create components/ImagePreloader that encapsulates process of loading image
  • Make sure components/Image is using components/ImagePreloader to load image and utils/vignette to get the low quality image
  • Add support to non-vignette images to components/Image
  • Remove components/Vignette, as it should be replaced by either components/Imageor a combination of utils/vignette and regular <img /> tag.

@JoshuaRogan JoshuaRogan added the wip Work in progress label Mar 19, 2019
@JoshuaRogan JoshuaRogan requested a review from vforge as a code owner March 19, 2019 21:58
JoshuaRogan
JoshuaRogan commented Mar 20, 2019
View reviewed changes
@vforge vforge force-pushed the advanced-image-view branch from dd96aa2 to 88cec7d Compare March 20, 2019 23:35
JoshuaRogan
JoshuaRogan commented Mar 21, 2019
View reviewed changes
@vforge
Copy link
Collaborator

vforge commented Mar 22, 2019

I want to merge it with Vignette and add handling for non-Vigentte images.

@vforge vforge force-pushed the advanced-image-view branch 3 times, most recently from 760257f to 70706b0 Compare March 25, 2019 22:06
@vforge vforge force-pushed the advanced-image-view branch from 70706b0 to 54088dd Compare March 25, 2019 23:58
@vforge vforge removed the wip Work in progress label Mar 26, 2019
JoshuaRogan
JoshuaRogan commented Mar 27, 2019
View reviewed changes
Copy link
Contributor Author

@JoshuaRogan JoshuaRogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can't approve though

@vforge
Copy link
Collaborator

vforge commented Mar 27, 2019

I can :)

@vforge vforge merged commit f2abe60 into master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vforge vforge vforge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaRogan @vforge