Skip to content
This repository was archived by the owner on Jan 21, 2019. It is now read-only.

Conversation

xkxd
Copy link
Contributor

@xkxd xkxd commented Aug 1, 2018

+ change box-sizing of field
+ change autoresize logic

@xkxd xkxd requested review from latata and vforge August 1, 2018 12:25
Copy link
Collaborator

@vforge vforge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works ok, missing tests for error states (yarn coverage)

@coveralls
Copy link

coveralls commented Aug 1, 2018

Pull Request Test Coverage Report for Build 294

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 291: 0.0%
Covered Lines: 204
Relevant Lines: 204

💛 - Coveralls

@vforge vforge merged commit 78e23de into master Aug 1, 2018
@vforge vforge deleted the make-label-conditionally-optional branch August 1, 2018 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants