This repository was archived by the owner on Jan 21, 2019. It is now read-only.
Add Avatar component #49
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vforge
reviewed
Aug 6, 2018
src/components/Avatar/index.js
Outdated
| import './styles.scss'; | ||
|
|
||
| const Avatar = props => ( | ||
| <div className={`avatar ${props.className}`}> |
There was a problem hiding this comment.
Can we go with wds-avatar instead of making our own? https://fandomdesignsystem.com/#/components/avatars
There was a problem hiding this comment.
Yeah, interesting. I copied this from our repo. I'm going to talk with derek to make sure we are consistent on the design and then I will make the changes
|
I updated some of the design to closer match fandom design system. There is still lots of features to add but this is a good start IMO. |
|
DS Avatar is now added - please update and reopen PR if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.