-
Notifications
You must be signed in to change notification settings - Fork 0
Icon component 2nd attempt #53
Conversation
vforge
commented
Aug 12, 2018
- It's still using the sprite, but it should be better now
- I have an idea I want to follow up it with, but it's ok for now.
3015ad1
to
db7805e
Compare
Pull Request Test Coverage Report for Build 333
💛 - Coveralls |
db7805e
to
2f3de1c
Compare
```js | ||
<BannerNotifications messages={[]} onClick={() => {}} /> | ||
<div> | ||
<IconSprite /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need to be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to include it on the solo example page https://wikia.github.io/react-design-system/#!/BannerNotifications , in fact we'll need it in all the components that are using Icon
component now in all the examples. I'll add this there too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mklucsarits I've added comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍