Skip to content
This repository was archived by the owner on Jan 21, 2019. It is now read-only.

Conversation

vforge
Copy link
Collaborator

@vforge vforge commented Aug 21, 2018

No description provided.

@vforge vforge requested a review from xkxd August 21, 2018 03:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 357

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 356: 0.0%
Covered Lines: 224
Relevant Lines: 224

💛 - Coveralls

return (this.props.autoFocus || this.props.forceFocus) && !this.props.disabled && !this.props.readonly;
}

isForceFocus() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small note, maybe we should call it should(Force/Auto)Focus?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is an internal function, let's do it in separate PR.

@vforge vforge merged commit dff0bcc into master Aug 21, 2018
@vforge vforge deleted the autofocus-fix branch August 21, 2018 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants