-
Notifications
You must be signed in to change notification settings - Fork 0
New build process #71
Conversation
I think nearly all of these files should be generated on |
@@ -0,0 +1,366 @@ | |||
'use strict'; | |||
|
|||
function _interopDefault (ex) { return (ex && (typeof ex === 'object') && 'default' in ex) ? ex['default'] : ex; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is all this extra code auto-generated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes!
@v Can you explain a bit more what's going on here? Like what the extra code is doing and how it's generated? |
@JoshuaRogan Unfortunately because of our licensing we won't publish this package to npm.js. There are other ideas floating around, but for now everything stays on GH. @mklucsarits Sure, let me add READMEs and some description during the weekend and we'll get back to this PR next week. |
d3e0af0
to
2fc7c01
Compare
2fc7c01
to
2f330b1
Compare
I believe you can run it during npm |
|
I'll in the process of updating docs/readmes so it's clear why it's like that right now. |
5c7355d
to
04c4dcd
Compare
04c4dcd
to
9b07625
Compare
@mklucsarits and @JoshuaRogan I've updated PR and added a description. Hopefully, it's clearer now. |
@mklucsarits automated dismiss, sorry about that! I turned it off |
@vforge Can we use artifactory to host the content? It really sucks having the build files in the repo. |
@JoshuaRogan I'll work on that. |
Move all the source files to
source
directory.Update READMEs everywhere.
For now (until we have private npm account or artifactory) we cannot publish the package, so the output files need to stay in this repo.
I do not want the client to download X libraries that are not needed in order to use the RDS (like Ember is needed for the DS itself), so the process is compiling all the files into ES5 and you only need React, ReactDOM and PropTypes in order to use them. The client shouldn't care if an RDS component needs lodash or anything else.
For the reason above I do not want to have a post-install process. In the future, the build should happen only before the package is published.
NOTE: This PR does not contain build files, because I wanted it to be easier to read. Once it's clear, I'll add the result of
yarn build
.