This repository was archived by the owner on Jan 21, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e0b458f
IW-1244 | Extending DropdownToggle capabilities
bkoval 9f8ef50
IW-1244 | Tests
bkoval 921dc60
IW-1244 | Fixing className for toggle
bkoval a3aeab7
IW-1244 | Removing obsolete test, regenerating snapshots
bkoval 57cab8a
IW-1244 | Build
bkoval e393c88
IW-1244 | Adding possibility to define custom icon in dropdown toggle
bkoval a247b1e
IW-1244 | Dropdowns updated
bkoval 1de3d46
IW-1244 | Linter
bkoval 11ae2ec
IW-1244 build
rybmat e74fe8b
IW-1244: isStickedToParent prop
rybmat f6022a0
IW-1244 fix linter
rybmat 56d2780
IW-1244 | Revamping DropdownToggle, rewriting tests for it
bkoval d93baf4
IW-1244 | Linter
bkoval f746243
IW-1244 | Regenerated snapshots
bkoval 3c40605
IW-1244 | onClose, tests
bkoval a621145
IW-1244 | Linter
bkoval da3984e
IW-1244 | Addressing comments
bkoval 01c9746
IW-1244 | Adding more tests for Dropdown component
bkoval dddf878
IW-1244 | Build
bkoval f6fcb4c
IW-1244 | Fixing unit tests
bkoval 446bf94
IW-1244 | Linter
bkoval a52dc0a
IW-1244 | Addressing CR
bkoval 36eb9dd
Merge branch 'master' into IW-1244
bkoval 816ffea
IW-1244 | Linter, removing defaultProp
bkoval 37d48b6
IW-1244 | Regenerating snapshots for dropdown component
bkoval File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
<!DOCTYPE html><html><head><meta charset="UTF-8"><meta name="viewport" content="width=device-width, initial-scale=1.0"><meta http-equiv="X-UA-Compatible" content="ie=edge"><title>react-design-system</title><link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Rubik:400,700"></head><body><div id="rsg-root"></div><div id="app"></div><script src="build/bundle.3adf5f6e.js"></script></body></html> | ||
<!DOCTYPE html><html><head><meta charset="UTF-8"><meta name="viewport" content="width=device-width, initial-scale=1.0"><meta http-equiv="X-UA-Compatible" content="ie=edge"><title>react-design-system</title><link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Rubik:400,700"></head><body><div id="rsg-root"></div><div id="app"></div><script src="build/bundle.46116394.js"></script></body></html> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to support jsx toggle content as well?
Or function and string is enough? :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSX is the else in this case :)