Skip to content
This repository was archived by the owner on Jan 21, 2019. It is now read-only.

Conversation

nmonterroso
Copy link
Contributor

@Wikia/lore
fixes some issues with the Select input after using it in the taxonomy-front-end:

  • background color for the wrapper did not match that of the actual select component
  • custom class was being applied to the react-select component, not the wrapper
  • onBlur was not being called with up-to-date values since they are not immediately available. To avoid this I'm manually firing onBlur after onChange and preventing the default onBlur behavior if it followed an onChange.

@nmonterroso nmonterroso requested a review from vforge as a code owner November 27, 2018 20:32
@coveralls
Copy link

Pull Request Test Coverage Report for Build 530

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 529: 0.0%
Covered Lines: 350
Relevant Lines: 350

💛 - Coveralls

@vforge vforge merged commit d5ecb2e into master Nov 27, 2018
@vforge vforge deleted the select-input-fixes branch November 27, 2018 20:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants