This repository was archived by the owner on Jan 21, 2019. It is now read-only.
IW-1347 | set isTouchDevice in dropdown within commponentDidMount method #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latata
approved these changes
Nov 30, 2018
hakubo
reviewed
Nov 30, 2018
|
|
||
| componentDidMount() { | ||
| this.setState({ | ||
| isTouchDevice: typeof window !== 'undefined' && ('ontouchstart' in window), |
There was a problem hiding this comment.
We'll go with this solution to unblock development since we're wrapping up dropdowns, but let's keep discussion open about patterns like this.
This code is moved to componentDidMount as we know for sure it runs immediately component is mount on the browser side - this way we overwrite the isTouchDevice value which is set to false on the SSR side immediately after rendering the component.
bkoval
approved these changes
Dec 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes issues on mobile safari where in some cases user needed to tap twice in order to see dropdown content
@Wikia/iwing