This repository was archived by the owner on Jan 21, 2019. It is now read-only.
Add additional badyarges to proptypes #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsutterfield
commented
Jan 15, 2019
source/components/Avatar/index.js
Outdated
| [ | ||
| 'admin', 'content-moderator', 'discussion-moderator', | ||
| 'global-discussions-moderator', 'helper', 'staff', 'vstf', | ||
| 'admin', 'content-moderator', 'discussion-moderator','sysop', |
There was a problem hiding this comment.
In addition to empty string, sysop is also possible. See here: https://github.com/Wikia/pandora/blob/master/service/discussion/src/main/java/com/wikia/discussionservice/services/BadgePermissionsResolver.java#L14
latata
approved these changes
Jan 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Avatarcomponent was missing a couple possible values from theproptypesof itsbadgemember variable which resulted in warnings. This PR adds those possible values./cc @Wikia/iwing