Don't create duplicate Bundle authorization when non-available resources are moved to Bundle

[lalit97]

Description

When a partner is moved from an access method to Bundle we do some processing in update_existing_bundle_authorizations to update authorizations accordingly.

When the partner is set to one of the non-available statuses and is moved to Bundle, it creates duplicate Bundle authorizations for users. This shouldn't happen.

Rationale

When the partner is set to one of the non-available statuses and is moved to Bundle in the same operation,
it creates duplicate Bundle authorizations for the user. This should not happen ideally.

Phabricator Ticket

https://phabricator.wikimedia.org/T302882

How Has This Been Tested?

I have tested it by moving a partner from available to waitlist and setting its authorization_method to Bundle in the same query. Later checked that it does not have duplicate Authorizations in the DB.

Screenshots of your changes (if appropriate):

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Minor change (fix a typo, add a translation tag, add section to README, etc.)

[suecarmol]

Hi @lalit97! We are having some trouble trying to reproduce this error. Could you please add detailed instructions about how you reproduced this bug and the queries you made to check that

1. the duplicate authorizations were created
2. the bug was fixed when you made your changes.

[suecarmol]

Hi @lalit97! We are having some trouble trying to reproduce this error. Could you please add detailed instructions about how you reproduced this bug and the queries you made to check that

1. the duplicate authorizations were created

2. the bug was fixed when you made your changes.

I was able to reproduce this bug and added the steps to reproduce it to the Phab task, although it will still be good to know how you reproduced this error in your own words :)

[suecarmol]

Thank you for working on this tricky bug fix. I have some initial minor comments,

[lalit97]

Hi @lalit97! We are having some trouble trying to reproduce this error. Could you please add detailed instructions about how you reproduced this bug and the queries you made to check that

1. the duplicate authorizations were created
2. the bug was fixed when you made your changes.

Hi @suecarmol sure, I will add the steps here soon :)
updates: I have posted the 1st part. I will post the 2nd part this weekend.

[lalit97]

1. the duplicate authorizations were created

First of all, I selected a Bundle eligible user (having wp_bundle_eligible=True). So the user was by default Authorized for all the partners who had the Bundle authorization_method.

In [1]: from TWLight.users.models import Authorization

In [2]: from django.contrib.auth.models import User

In [3]: user = User.objects.get(username="61329345")

In [4]: for auth in Authorization.objects.filter(user=user):
                 print(auth)
Out [4]:
authorized: Lalit97meta - authorizer: TWL Team - date_authorized: 2022-05-03 - company_name: Freudenberger, Geisler, Pohl, Sager KG, Salz, Zobel GbR

Then I created an application from that user for a non-Bundle partner (Austermühle) and approved it. So now there was a new Authorization for the user for that given partner.

In [5]: for auth in Authorization.objects.filter(user=user):
                 print(auth)
Out [5]: 
authorized: Lalit97meta - authorizer: TWL Team - date_authorized: 2022-05-03 - company_name: Freudenberger, Geisler, Pohl, Sager KG, Salz, Zobel GbR
authorized: Lalit97meta - authorizer: lalit_staff - date_authorized: 2022-05-03 - company_name: Austermühle

Then I changed the partner's status and authorization_method in a single operation like:

In [7]: from TWLight.resources.models import Partner
In [8]: partner = Partner.objects.get(id=48)

In [10]: partner.authorization_method == Partner.EMAIL
Out[10]: True

In [12]: partner.status == Partner.AVAILABLE
Out[12]: True

In [14]: partner.authorization_method = Partner.BUNDLE
In [15]: partner.status = Partner.WAITLIST
In [16]: partner.save()

I tried to print all the Authorizations for the user once again. I got these results:

In [17]: for auth in Authorization.objects.filter(user=user):
                   print(auth)
Out [17]:
authorized: Lalit97meta - authorizer: TWL Team - date_authorized: 2022-05-03 - company_name: Freudenberger, Geisler, Pohl, Sager KG, Salz, Zobel GbR
authorized: Lalit97meta - authorizer: lalit_staff - date_authorized: 2022-05-03 - company_name: Austermühle

The Austermühle partner is now Bundle. We know that only 1 Bundle type Authorization should be present for each user. But I still received 2 Authorization objects for the user. Both of them are for Bundle type partners. This is how I found that duplicate authorizations were created.

[jsnshrmn]

Sorry for the long wait on getting this approved. This looks great! Thanks for your help!

[lalit97]

No issues at all. Thank you for your words 😀