Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git diff fails when comparing files that differ only in file mode #615

Closed
kkrrz opened this issue Jan 2, 2024 · 4 comments
Closed

git diff fails when comparing files that differ only in file mode #615

kkrrz opened this issue Jan 2, 2024 · 4 comments
Labels

Comments

@kkrrz
Copy link

kkrrz commented Jan 2, 2024

The steps to reproduce are as follows.

$ git config diff.external difft
$ touch foo bar
$ chmod 755 foo
$ git diff --no-ext-diff --no-index foo bar
diff --git foo bar
old mode 100755
new mode 100644
$ git diff --no-index foo bar
Segmentation fault: 11
$ difft --version
Difftastic 0.53.1

Tested on macOS 13.6.3

@Wilfred
Copy link
Owner

Wilfred commented Jan 2, 2024

Thanks for the report. I think this might be a git issue: I can also replicate if the external diff is diff or cat.

@Wilfred Wilfred added the triaged label Jan 2, 2024
@Wilfred
Copy link
Owner

Wilfred commented Jan 28, 2024

I've reported upstream, the thread should soon appear in https://lore.kernel.org/git/ I think.

@Wilfred
Copy link
Owner

Wilfred commented Feb 29, 2024

Fixed upstream, thanks for the report!

@Wilfred Wilfred closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants