Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cleanup and no longer depend on loop #26

Merged
merged 7 commits into from
Aug 15, 2020

Conversation

tarsius
Copy link
Contributor

@tarsius tarsius commented Mar 20, 2020

Two years ago, in #21, I experimented with using magit-section.el in this package. Recently I released that library as separate package, so I picked that experiment up again. If nothing else it might serve as an example for how to use magit-section in a package that isn't Magit.

Anyway, I did some cleanup while working on that and now propose those changes using this this pull request.

I am aware that you are the author of loop but I still think you should avoid depending on an additional package just to make a single function slightly less more readable.

@coveralls
Copy link

coveralls commented Mar 20, 2020

Coverage Status

Coverage decreased (-4.2%) to 71.072% when pulling 1e96ed2 on tarsiiformes:cleanup into 0e7ea15 on Wilfred:master.

@tarsius
Copy link
Contributor Author

tarsius commented Mar 20, 2020

coveralls got that wrong.

@tarsius
Copy link
Contributor Author

tarsius commented May 28, 2020

Friendly ping!

@tarsius
Copy link
Contributor Author

tarsius commented Jul 6, 2020

And another friendly pint 🍺

@Wilfred Wilfred merged commit e2065ee into Wilfred:master Aug 15, 2020
@Wilfred
Copy link
Owner

Wilfred commented Aug 15, 2020

Thanks!

Yeah, loop.el taught me a lot about writing and testing elisp macros. I almost never find myself needing it in practice though, so I agree the code is better here without it.

Wilfred added a commit that referenced this pull request Aug 15, 2020
@tarsius tarsius deleted the cleanup branch August 16, 2020 07:22
@tarsius
Copy link
Contributor Author

tarsius commented Aug 16, 2020

You are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants