-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some cleanup and no longer depend on loop #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coveralls got that wrong. |
Also add the missing copyright holder.
Friendly ping! |
And another friendly pint 🍺 |
Thanks! Yeah, loop.el taught me a lot about writing and testing elisp macros. I almost never find myself needing it in practice though, so I agree the code is better here without it. |
Wilfred
added a commit
that referenced
this pull request
Aug 15, 2020
You are welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two years ago, in #21, I experimented with using
magit-section.el
in this package. Recently I released that library as separate package, so I picked that experiment up again. If nothing else it might serve as an example for how to usemagit-section
in a package that isn't Magit.Anyway, I did some cleanup while working on that and now propose those changes using this this pull request.
I am aware that you are the author of
loop
but I still think you should avoid depending on an additional package just to make a single function slightlylessmore readable.