Add support for following and storing org "help" links #304
Conversation
DamienCassou
force-pushed
the
support-org-help-links
branch
from
1e9b598
to
1caa560
Compare
DamienCassou
force-pushed
the
support-org-help-links
branch
from
1caa560
to
b82fb99
Compare
|
Thanks. |
| ;; helpful are loaded. To avoid using `eval-after-load' (which is | ||
| ;; only recommended in user init files), the function is called each | ||
| ;; time the major mode is used. | ||
| (helpful--add-support-for-org-links)) |
There was a problem hiding this comment.
The registration is not ideal. Calling the registration on every mode invocation is worse than using with-eval-after-load. The recommendation shouldn't be followed always, in fact it is harmful here. It leads to an actual initialization problem - as long as no helpful buffer has been created, help links are not registered for helpful.
To fix this it is sufficient to perform the registration in an with-eval-after-load 'org block in helpful.el at the toplevel. If the user wants to use helpful directly for Org help links they should then add (with-eval-after-load 'org (require 'helpful)) to their config. If loading helpful always with org is considered too heavy one could create a separate file helpful-ol, which doesn't directly load helpful. See my osm-ol package as an example: https://github.com/minad/osm/blob/main/osm-ol.el
There was a problem hiding this comment.
I'm fine implementing that if @Wilfred agrees.
Closes #38