Add a cert_store option #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mwrock can you accept this PR ? thanks |
|
Is this still relevant to merge? |
|
@pcai yes, we still use this branch on production. |
|
@pcai can you merge this ? I'm sad this isn't in today's release. |
|
I would've, if this had test coverage. Since it doesn't, I need to do a few manual checks for sanity. Perhaps later this week I can take a look |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
It would be great to be able to use the gem with for instance an in-memory certificate instead of a file!
This PR add the option to use a
cert_storeoption where it is currently possible to specify aca_trust_path(https://rubydoc.info/gems/httpclient/HTTPClient/SSLConfig)I would love to have your feedback on this,
Best regards,
Sulidi