This repository has been archived by the owner on Aug 25, 2022. It is now read-only.
Simple event handler implementation (with @Gounlaf) #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| foreach ($this->callbacks[$event] as $existingCallback) { | ||
| if ($existingCallback === $callback) { | ||
| $this->stdout('debug', 'Skip existing callback'); |
There was a problem hiding this comment.
Not sure that a comparision like that is really accurate...
There was a problem hiding this comment.
The comparison works for simple function (and should works with object); closure are logically not equals
There was a problem hiding this comment.
in_array can be more accurate ;
in both case (current code, or in_array), we must handle the case where $callback is a string (eg, the name of a function)
There was a problem hiding this comment.
Yup, I also think that in_array may be a better choice, as it is natively implemented
added 2 commits
April 3, 2014 15:46
…llows infinite loop to stop when close() is called
|
That seems great now. Thanks. |
guillaumepotier
added a commit
that referenced
this pull request
Apr 8, 2014
Simple event handler implementation (with @Gounlaf)
This was referenced Aug 1, 2014
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Here is a simple implementation of an event handler.
Made with ❤
Contributor: @Gounlaf