Feature/general improvements #360
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the CI/CD workflow, enhances code coverage handling for different environments, updates configuration files for modern PHPUnit compatibility, and makes minor bug fixes and documentation improvements. The most significant changes are grouped below.
CI/CD Workflow and Code Coverage Improvements:
.github/workflows/ci.yml
workflow has been updated to improve coverage handling: PCOV is explicitly installed, tests are run with coverage output, and coverage upload now uses a dedicated script (ci/run_coverage.sh
) for better compatibility and robustness. [1] [2] [3]ci/run_coverage.sh
(Bash) andci/coverage.php
(PHP) to conditionally run tests and generate coverage reports based on the presence of coverage drivers (xdebug/pcov), including fallback to placeholder coverage files if no driver is available. [1] [2]ci/generate_phpunit_config.php
to generate PHPUnit configuration files dynamically based on detected PHPUnit version, improving compatibility across environments.PHPUnit Configuration Modernization:
phpunit.xml.dist
to use the modern schema, with improved coverage configuration and removal of legacy<filter>
and<logging>
sections, making it compatible with PHPUnit 9+.Code Quality and Bug Fixes:
polyfill_filter_var_string
ingump.class.php
to properly escape single and double quotes and corrected a regex typo.gump.class.php
for several validators to ensure default values and type consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9]Testing Enhancements:
upper_case
filter intests/Filters/UpperCaseFilterTest.php
, covering a wide range of input scenarios including Unicode, special characters, and edge cases.Documentation and Metadata Updates:
composer.json
and copyright notice inLICENSE
. [1] [2]ArrayAccess
import insrc/ArrayHelpers.php
.