Core: add sniffs to check formatting of increment/decrement operators

WordPress-Core/ruleset.xml

@@ -217,6 +217,10 @@
 		</properties>
 	</rule>
 
+	<!-- Covers rule: When using increment or decrement operators, there should be
+		 no spaces between the operator and the variable it applies to. -->
+	<rule ref="Generic.WhiteSpace.IncrementDecrementSpacing"/>
+
 
 	<!--
 	#############################################################################
@@ -468,6 +472,19 @@
 	<rule ref="WordPress.PHP.NoSilencedErrors"/>
 
 
+	<!--
+	#############################################################################
+	Handbook: Operators - Increment/decrement operators.
+	Ref: https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#increment-decrement-operators
+	#############################################################################
+	-->
+	<!-- Covers rule: Pre-increment/decrement should be favoured over post-increment/decrement
+		 for stand-alone statements. -->
+	<rule ref="Universal.Operators.DisallowStandalonePostIncrementDecrement">
+		<type>warning</type>
+	</rule>
+
+
 	<!--
 	#############################################################################
 	Handbook: Database - Database Queries.

WordPress/Sniff.php

@@ -928,7 +928,7 @@ protected function get_last_ptr_on_line( $stackPtr ) {
 		$nextPtr     = ( $stackPtr + 1 );
 
 		while ( isset( $tokens[ $nextPtr ] ) && $tokens[ $nextPtr ]['line'] === $currentLine ) {
-			$nextPtr++;
+			++$nextPtr;
 			// Do nothing, we just want the last token of the line.
 		}
 

WordPress/Sniffs/Arrays/ArrayDeclarationSpacingSniff.php

@@ -405,7 +405,7 @@ protected function process_multi_line_array( $stackPtr, $opener, $closer ) {
 						&& substr( rtrim( $this->tokens[ $end_of_comment ]['content'] ), -2 ) !== '*/'
 						&& ( $end_of_comment + 1 ) < $end_of_this_item
 					) {
-						$end_of_comment++;
+						++$end_of_comment;
 					}
 
 					if ( $this->tokens[ $end_of_comment ]['line'] !== $this->tokens[ $end_of_last_item ]['line'] ) {

WordPress/Sniffs/Arrays/CommaAfterArrayItemSniff.php

@@ -188,7 +188,7 @@ public function process_token( $stackPtr ) {
 
 					if ( \T_WHITESPACE === $this->tokens[ $i ]['code'] ) {
 						if ( $this->tokens[ $i ]['content'] === $this->phpcsFile->eolChar ) {
-							$newlines++;
+							++$newlines;
 						} else {
 							$spaces += $this->tokens[ $i ]['length'];
 						}

WordPress/Sniffs/Arrays/MultipleStatementAlignmentSniff.php

@@ -358,7 +358,7 @@ protected function process_multi_line_array( $stackPtr, $items, $opener, $closer
 				$items[ $key ]['single_line'] = true;
 			} else {
 				$items[ $key ]['single_line'] = false;
-				$multi_line_count++;
+				++$multi_line_count;
 			}
 
 			if ( ( $index_end_position + 2 ) <= $this->maxColumn ) {
@@ -368,7 +368,7 @@ protected function process_multi_line_array( $stackPtr, $items, $opener, $closer
 			if ( ! isset( $double_arrow_cols[ $this->tokens[ $double_arrow ]['column'] ] ) ) {
 				$double_arrow_cols[ $this->tokens[ $double_arrow ]['column'] ] = 1;
 			} else {
-				$double_arrow_cols[ $this->tokens[ $double_arrow ]['column'] ]++;
+				++$double_arrow_cols[ $this->tokens[ $double_arrow ]['column'] ];
 			}
 		}
 		unset( $key, $item, $double_arrow, $has_array_opener, $last_index_token );
@@ -413,7 +413,7 @@ protected function process_multi_line_array( $stackPtr, $items, $opener, $closer
 				if ( ! isset( $double_arrow_cols[ $this->tokens[ $item['operatorPtr'] ]['column'] ] ) ) {
 					$double_arrow_cols[ $this->tokens[ $item['operatorPtr'] ]['column'] ] = 1;
 				} else {
-					$double_arrow_cols[ $this->tokens[ $item['operatorPtr'] ]['column'] ]++;
+					++$double_arrow_cols[ $this->tokens[ $item['operatorPtr'] ]['column'] ];
 				}
 			}
 		}

WordPress/Sniffs/NamingConventions/ValidHookNameSniff.php

@@ -178,10 +178,10 @@ public function process_parameters( $stackPtr, $group_name, $matched_content, $p
 			}
 
 			if ( $string !== $case_transform ) {
-				$case_errors++;
+				++$case_errors;
 			}
 			if ( $string !== $punct_transform ) {
-				$underscores++;
+				++$underscores;
 			}
 		}
 
@@ -270,18 +270,18 @@ protected function transform_complex_string( $string, $regex, $transform_type =
 				$is_variable = true;
 				if ( '{' === $part ) {
 					$has_braces = true;
-					$braces++;
+					++$braces;
 				}
 				continue;
 			}
 
 			if ( true === $is_variable ) {
 				if ( '[' === $part ) {
 					$has_braces = true;
-					$braces++;
+					++$braces;
 				}
 				if ( \in_array( $part, array( '}', ']' ), true ) ) {
-					$braces--;
+					--$braces;
 				}
 				if ( false === $has_braces && ' ' === $part ) {
 					$is_variable  = false;

WordPress/Sniffs/Security/EscapeOutputSniff.php

@@ -263,7 +263,7 @@ public function process_token( $stackPtr ) {
 		}
 
 		// Ignore the function itself.
-		$stackPtr++;
+		++$stackPtr;
 
 		$in_cast = false;
 
@@ -315,7 +315,7 @@ public function process_token( $stackPtr ) {
 
 			// Handle arrays for those functions that accept them.
 			if ( \T_ARRAY === $this->tokens[ $i ]['code'] ) {
-				$i++; // Skip the opening parenthesis.
+				++$i; // Skip the opening parenthesis.
 				continue;
 			}
 

WordPress/Sniffs/WP/GlobalVariablesOverrideSniff.php

@@ -332,7 +332,7 @@ protected function process_global_statement( $stackPtr, $in_function_scope ) {
 				}
 			}
 
-			$ptr++;
+			++$ptr;
 		}
 		unset( $var );
 

WordPress/Sniffs/WhiteSpace/ControlStructureSpacingSniff.php

@@ -561,7 +561,7 @@ public function process_token( $stackPtr ) {
 					$i = ( $scopeCloser + 1 );
 					while ( $this->tokens[ $i ]['line'] !== $this->tokens[ $trailingContent ]['line'] ) {
 						$this->phpcsFile->fixer->replaceToken( $i, '' );
-						$i++;
+						++$i;
 					}
 
 					// TODO: Instead a separate error should be triggered when content comes right after closing brace.