Releases: WordPress/WordPress-Coding-Standards
1.2.1
Note: This will be the last release supporting PHP_CodeSniffer 2.x.
Changed
- The default value for
minimum_supported_wp_version
, as used by a number of sniffs detecting usage of deprecated WP features, has been updated to4.7
. - The
WordPress.NamingConventions.PrefixAllGlobals
sniff will now report the error for hook names and constant names declared withdefine()
on the line containing the parameter for the hook/constant name. Previously, it would report the error on the line containing the function call. - Various minor housekeeping fixes to inline documentation, rulesets, code.
Removed
comment_author_email_link()
,comment_author_email()
,comment_author_IP()
,comment_author_link()
,comment_author_rss()
,comment_author_url_link()
,comment_author_url()
,comment_author()
,comment_date()
,comment_excerpt()
,comment_form_title()
,comment_form()
,comment_id_fields()
,comment_ID()
,comment_reply_link()
,comment_text_rss()
,comment_text()
,comment_time()
,comment_type()
,comments_link()
,comments_number()
,comments_popup_link()
,comments_popup_script()
,comments_rss_link()
,delete_get_calendar_cache()
,edit_bookmark_link()
,edit_comment_link()
,edit_post_link()
,edit_tag_link()
,get_footer()
,get_header()
,get_sidebar()
,get_the_title()
,next_comments_link()
,next_image_link()
,next_post_link()
,next_posts_link()
,permalink_anchor()
,posts_nav_link()
,previous_comments_link()
,previous_image_link()
,previous_post_link()
,previous_posts_link()
,sticky_class()
,the_attachment_link()
,the_author_link()
,the_author_meta()
,the_author_posts_link()
,the_author_posts()
,the_category_rss()
,the_category()
,the_content_rss()
,the_content()
,the_date_xml()
,the_excerpt_rss()
,the_excerpt()
,the_feed_link()
,the_ID()
,the_meta()
,the_modified_author()
,the_modified_date()
,the_modified_time()
,the_permalink()
,the_post_thumbnail()
,the_search_query()
,the_shortlink()
,the_tags()
,the_taxonomies()
,the_terms()
,the_time()
,the_title_rss()
,the_title()
,wp_enqueue_script()
,wp_meta()
,wp_shortlink_header()
andwp_shortlink_wp_head()
from the list of auto-escaped functionsSniff::$autoEscapedFunctions
. This affects theWordPress.Security.EscapeOutput
sniff.
Fixed
- The
WordPress.WhiteSpace.PrecisionAlignment
sniff would loose the value of a custom setignoreAlignmentTokens
property when scanning more than one file.
1.2.0
Added
- New
WordPress.PHP.TypeCasts
sniff to theWordPress-Core
ruleset.
This new sniff checks that PHP type casts are:- lowercase;
- short form, i.e.
(bool)
not(boolean)
; - normalized, i.e.
(float)
not(real)
.
Additionally, the new sniff discourages the use of the(unset)
and(binary)
type casts.
- New
WordPress.Utils.I18nTextDomainFixer
sniff which can compehensively replace/addtext-domain
s in a plugin or theme.
Important notes:- This sniff is disabled by default and intended as a utility tool.
- The sniff will fix the text domains in all I18n function calls as well as in a plugin/theme
Text Domain:
header. - Passing the following properties will activate the sniff:
old_text_domain
: an array with one or more (old) text domains which need to be replaced;new_text_domain
: the correct (new) text domain as a string.
- The
WordPress.NamingConventions.PrefixAllGlobals
sniff will now also verify that namespace names use a valid prefix.- The sniff allows for underscores and (other) non-word characters in a passed prefix to be converted to namespace separators when used in a namespace name.
In other words, if a prefix ofmy_plugin
is passed as a value to theprefixes
property, a namespace name of bothMy\Plugin
as well asMy_Plugin\\
, will be accepted automatically. - Passing a prefix property value containing namespace separators will now also be allowed and will no longer trigger a warning.
- The sniff allows for underscores and (other) non-word characters in a passed prefix to be converted to namespace separators when used in a namespace name.
WordPress
to the prefix blacklist for theWordPress.NamingConventions.PrefixAllGlobals
sniff.
While the prefix cannot beWordPress
, a prefix can still start with or containWordPress
.- Additional unit tests covering a change in the tokenizer which will be included in the upcoming
PHP_CodeSniffer
3.4.0 release. - A variety of issue templates for use on GitHub.
Changed
- The
Sniff::valid_direct_scope()
method will now return the$stackPtr
to the valid scope if a valid direct scope has been detected. Previously, it would returntrue
. - Minor hardening and efficiency improvements to the
WordPress.NamingConventions.PrefixAllGlobals
sniff. - The inline documentation of the
WordPress-Core
ruleset has been updated to be in line again with the handbook. - The inline links to documentation about the VIP requirements have been updated.
- Updated the custom ruleset example to recommend using
PHPCompatibilityWP
rather thanPHPCompatibility
. - All sniffs are now also being tested against PHP 7.3 for consistent sniff results.
Note: PHP 7.3 is only supported in combination with PHPCS 3.3.1 or higher asPHP_CodeSniffer
itself has an incompatibility in earlier versions. - Minor grammar fixes in text strings and documentation.
- Minor consistency improvement for the unit test case files.
- Minor tweaks to the
composer.json
file. - Updated the PHPCompatibility
dev
dependency.
Removed
- The
WordPress.WhiteSpace.CastStructureSpacing.NoSpaceAfterCloseParenthesis
error code as an error for the same issue was already being thrown by an included upstream sniff.
Fixed
- The
WordPress.CodeAnalysis.EmptyStatement
would throw a false positive for an empty condition in afor()
statement. - The
Sniff::is_class_property()
method could, in certain circumstances, incorrectly recognize parameters in a method declaration as class properties. It would also, incorrectly, fail to recognize class properties when the object they are declared in, was nested in parentheses.
This affected, amongst others, theGlobalVariablesOverride
sniff. - The
Sniff::get_declared_namespace_name()
method could get confused over whitespace and comments within a namespace name, which could lead to incorrect results (mostly underreporting).
This affected, amongst others, theGlobalVariablesOverride
sniff.
The return value of the method will now no longer contain any whitespace or comments encountered. - The
Sniff::has_whitelist_comment()
method would sometimes incorrectly regard// phpcs:set
comments as whitelist comments.
1.1.0
Added
- New
WordPress.PHP.NoSilencedErrors
sniff. This sniff replaces theGeneric.PHP.NoSilencedErrors
sniff which was previously used and included in theWordPress-Core
ruleset.
The WordPress specific version of the sniff differs from the PHPCS version in that it:- Allows the error control operator
@
if it preceeds a function call to a limited list of PHP functions for which no amount of error checking can prevent a PHP warning from being thrown. - Allows for a used-defined list of (additional) function names to be passed to the sniff via the
custom_whitelist
property in a custom ruleset, for which - if the error control operator is detected in front of a function call to one of the functions in this whitelist - no warnings will be thrown. - Displays a brief snippet of code in the
warning
message text to show the context in which the error control operator is being used. The length of the snippet (in tokens) can be customized via thecontext_length
property. - Contains a public
use_default_whitelist
property which can be set from a custom ruleset which regulates whether or not the standard whitelist of PHP functions should be used by the sniff.
The user-defined whitelist will always be respected.
By default, this property is set totrue
for theWordPress-Core
ruleset and tofalse
for theWordPress-Extra
ruleset (which is stricter regarding these kind of best practices).
- Allows the error control operator
- Metrics to the
WordPress.NamingConventions.PrefixAllGlobals
sniff to aid people in determining the most commonly used prefix in a legacy project.
For an example of how to use this feature, please see the detailed explanation in the pull request.
Changed
- The
PEAR.Functions.FunctionCallSignature
sniff, which is part of theWordPress-Core
ruleset, used to allow multiple function call parameters per line in multi-line function calls. This will no longer be allowed.
As of this release, if a function call is multi-line, each parameter should start on a new line and anerror
will be thrown if the code being analysed does not comply with that rule.
The sniff behaviour for single-line function calls is not affected by this change. - Moved the
WordPress.CodeAnalysis.EmptyStatement
sniff from theWordPress-Extra
to theWordPress-Core
ruleset. - Moved the
Squiz.PHP.CommentedOutCode
sniff from theWordPress-Docs
to theWordPress-Extra
ruleset and lowered the threshold for determining whether or not a comment is commented out code from 45% to 40%. - The
WordPress.NamingConventions.PrefixAllGlobals
sniff now has improved support for recognizing whether or not (non-prefixed) globals are declared in the context of unit tests. - The
is_foreach_as()
method has been moved from theGlobalVariablesOverrideSniff
class to the WordPressSniff
base class. - The
Sniff::is_token_in_test_method()
utility method now has improved support for recognizing test methods in anonymous classes. - Minor efficiency improvement to the
Sniff::is_safe_casted()
method. - CI: Minor tweaks to the Travis script.
- CI: Improved Composer scripts for use by WPCS developers.
- Dev: Removed IDE specific files from
.gitignore
. - Readme: Improved the documentation about the project history and the badge display.
Fixed
- The
WordPress.Security.ValidatedSanitizedInput
sniff will now recognize array keys in superglobals independently of the string quote-style used for the array key. - The
WordPress.WhiteSpace.PrecisionAlignment
sniff will no longer throw false positives for DocBlocks for JavaScript functions within inline HTML. WordPress.WP.DeprecatedClasses
: The error codes for this sniff were unstable as they were based on the code being analysed instead of on fixed values.- Various bugfixes for the
WordPress.WP.GlobalVariablesOverride
sniff:- Previously, the sniff only checked variables in the global namespace when a
global
statement would be encountered. As of now, all variable assignments in the global namespace will be checked. - Nested functions/closures/classes which don't import the global variable will now be skipped over when encountered within another function, preventing false positives.
- Parameters in function declarations will no longer throw false positives.
- The error message for assignments to a subkey of the
$GLOBALS
superglobal has been improved. - Various efficiency improvements.
- Previously, the sniff only checked variables in the global namespace when a
- The
Sniff::is_in_isset_or_empty()
method presumed the WordPress coding style regarding code layout, which could lead to incorrect results (mostly underreporting).
This affected, amongst others, theWordPress.Security.ValidatedSanitizedInput
sniff. - Broken links in the inline developer documentation.
1.0.0
Important information about this release:
If you use the WordPress Coding Standards with a custom ruleset, please be aware that a number of sniffs have been moved between categories and that the old sniff names have been deprecated.
If you selectively include any of these sniffs in your custom ruleset or set custom property values for these sniffs, your custom ruleset will need to be updated.
The WordPress-VIP
ruleset has also been deprecated. If you used that ruleset to check your theme/plugin for hosting on the WordPress.com VIP platform, please use the Automattic VIP coding standards instead.
If you used that ruleset for any other reason, you should probably use the WordPress-Extra
or WordPress
ruleset instead.
These and some related changes have been annotated in detail in the Deprecated
section of this changelog.
Please read the complete changelog carefully before you upgrade.
If you are a maintainer of an external standard based on WPCS and any of your custom sniffs are based on or extend WPCS sniffs, the same applies.
Added
WordPress.PHP.PregQuoteDelimiter
sniff to theWordPress-Extra
ruleset to warn about calls topreg_quote()
which don't pass the$delimiter
parameter.WordPress.Security.SafeRedirect
sniff to theWordPress-Extra
ruleset to warn about potential open redirect vulnerabilities.WordPress.WP.DeprecatedParameterValues
sniff to theWordPress-Extra
ruleset to detect deprecated parameter values being passed to select functions.WordPress.WP.EnqueuedResourceParameters
sniff to theWordPress-Extra
ruleset to detect:- Calls to the script/style register/enqueue functions which don't pass a
$version
for the script/style, which can cause issues with browser caching; and/or - Calls to the register/enqueue script functions which don't pass the
$in_footer
parameter, which causes scripts - by default - to be loaded in the HTML header in a layout rendering blocking manner.
- Calls to the script/style register/enqueue functions which don't pass a
- Detection of calls to
strip_tags()
and various PHP native..rand()
functions to theWordPress.WP.AlternativeFunctions
sniff. readonly()
to the list of auto-escaped functionsSniff::$autoEscapedFunctions
. This affects theWordPress.Security.EscapeOutput
sniff.- The
WordPress.Security.PluginMenuSlug
,WordPress.WP.CronInterval
,WordPress.WP.PostsPerPage
andWordPress.WP.TimezoneChange
sniffs are now included in theWordPress-Extra
ruleset. Previously, they were already included in theWordPress
andWordPress-VIP
rulesets. - New utility method
Sniff::is_use_of_global_constant()
. - A rationale to the package suggestion made via
composer.json
. - CI: Validation of the
composer.json
file on each build. - A wiki page with instructions on how to set up WPCS to run with Eclipse on XAMPP.
- Readme: A link to an external resource with more examples for setting up PHPCS for CI.
- Readme: A badge-based quick overview of the project.
Changed
- The
WordPress
ruleset no longer includes theWordPress-VIP
ruleset, nor does it include any of the (deprecated)VIP
sniffs anymore. - The following sniffs have been moved to a new category:
CronInterval
from theVIP
category to theWP
category.DirectDatabaseQuery
from theVIP
category to theDB
category.DontExtract
from theFunctions
category to thePHP
category.EscapeOutput
from theXSS
category to theSecurity
category.GlobalVariables
from theVariables
category to theWP
category.NonceVerification
from theCSRF
category to theSecurity
category.PluginMenuSlug
from theVIP
category to theSecurity
category.PreparedSQL
from theWP
category to theDB
category.SlowDBQuery
from theVIP
category to theDB
category.TimezoneChange
from theVIP
category to theWP
category.ValidatedSanitizedInput
from theVIP
category to theSecurity
category.
- The
WordPress.VIP.PostsPerPage
sniff has been split into two distinct sniffs:WordPress.WP.PostsPerPage
which will check for the use of a high pagination limit and will throw awarning
when this is encountered. For theVIP
ruleset, the error level remainserror
.WordPress.VIP.PostsPerPage
wich will check for disabling of pagination.
- The default value for
minimum_supported_wp_version
, as used by a number of sniffs detecting usage of deprecated WP features, has been updated to4.6
. - The
WordPress.WP.AlternativeFunctions
sniff will now only throw a warning if/when the recommended alternative function is available in the minimum supported WP version of a project.
In addition to this, certain alternatives are only valid alternatives in certain circumstances, like when the WP version only supports the first parameter of the PHP function it is trying to replace.
This will now be taken into account for:wp_strip_all_tags()
is only a valid alternative for the PHP nativestrip_tags()
when the second parameter$allowed_tags
has not been passed.wp_parse_url()
only added support for the second parameter$component
of the PHP nativeparse_url()
function in WP 4.7.0.
- The
WordPress.WP.DeprecatedFunctions
sniff will now detect functions deprecated in WP 4.9. - The
WordPress.WP.GlobalVariablesOverride
sniff will now display the name of the variable being overridden in the error message. - The
WordPress.WP.I18n
sniff now extends theAbstractFunctionRestrictionSniff
. - Assignments in conditions in ternaries as detected by the
WordPress.CodeAnalysis.AssignmentInCondition
sniff will now be reported under a separate error codeFoundInTernaryCondition
. - The default error level for the notices from the
WordPress.DB.DirectDatabaseQuery
sniff has been lowered fromerror
towarning
. For theVIP
ruleset, the error level remainserror
. - The default error level for the notices from the
WordPress.Security.PluginMenuSlug
sniff has been lowered fromerror
towarning
. For theVIP
ruleset, the error level remainserror
. - The default error level for the notices from the
WordPress.WP.CronInterval
sniff has been lowered fromerror
towarning
. For theVIP
ruleset, the error level remainserror
. - The
Sniff::get_function_call_parameters()
utility method now has improved handling of closures when passed as function call parameters. - Rulesets: a number of error codes were previously silenced by explicitly
exclude
-ing them. Now, they will be silenced by setting theseverity
to0
which makes it more easily discoverable for maintainers of custom rulesets how to enable these error codes again. - Various performance optimizations which should most notably make a difference when running WPCS on PHP 7.
- References to the WordPress.com VIP platform have been clarified.
- Unit Tests: custom properties set in unit test files are reset after use.
- Various improvements to the ruleset used by the WPCS project itself and minor code clean up related to this.
- CI: Each change will now also be tested against the lowest supported PHPCS 3 version.
- CI: Each change will now also be checked for PHP cross-version compatibility.
- CI: The rulesets will now also be tested on each change to ensure no unexpected messages are thrown.
- CI: Minor changes to the script to make the build testing faster.
- Updated the custom ruleset example for the changes contained in this release and to reflect current best practices regarding the PHPCompatibility standard.
- The instructions on how to set up WPCS for various IDEs have been moved from the
README
to the wiki. - Updated output examples in
README.md
andCONTRIBUTING.md
and other minor changes to these files. - Updated references to the PHPCompatibility standard to reflect its new location and recommend using PHPCompatibilityWP.
Deprecated
- The
WordPress-VIP
ruleset has been deprecated.
For checking a theme/plugin for hosting on the WordPress.com VIP platform, please use the Automattic VIP coding standards instead.
If you used theWordPress-VIP
ruleset for any other reason, you should probably use theWordPress-Extra
orWordPress
ruleset instead. - The following sniffs have been deprecated and will be removed in WPCS 2.0.0:
WordPress.CSRF.NonceVerification
- useWordPress.Security.NonceVerification
instead.WordPress.Functions.DontExtract
- useWordPress.PHP.DontExtract
instead.WordPress.Variables.GlobalVariables
- useWordPress.WP.GlobalVariablesOverride
instead.WordPress.VIP.CronInterval
- useWordPress.WP.CronInterval
instead.WordPress.VIP.DirectDatabaseQuery
- useWordPress.DB.DirectDatabaseQuery
instead.WordPress.VIP.PluginMenuSlug
- useWordPress.Security.PluginMenuSlug
instead.WordPress.VIP.SlowDBQuery
- useWordPress.DB.SlowDBQuery
instead.WordPress.VIP.TimezoneChange
- useWordPress.WP.TimezoneChange
instead.WordPress.VIP.ValidatedSanitizedInput
- useWordPress.Security.ValidatedSanitizedInput
instead.WordPress.WP.PreparedSQL
- useWordPress.DB.PreparedSQL
instead.WordPress.XSS.EscapeOutput
- useWordPress.Security.EscapeOutput
instead.- `WordPress.VIP.AdminBarRemova...
0.14.1
0.14.0
Added
WordPress.Arrays.MultipleStatementAlignment
sniff to theWordPress-Core
ruleset which will align the array assignment operator for multi-item, multi-line associative arrays.
This new sniff offers four custom properties to customize its behaviour:ignoreNewlines
,exact
,maxColumn
andalignMultilineItems
.WordPress.DB.PreparedSQLPlaceholders
sniff to theWordPress-Core
ruleset which will analyse the placeholders passed to$wpdb->prepare()
for their validity, check whether queries usingIN ()
andLIKE
statements are created correctly and will check whether a correct number of replacements are passed.
This sniff should help detect queries which are impacted by the security fixes to$wpdb->prepare()
which shipped with WP 4.8.2 and 4.8.3.
The sniff also adds a new "PreparedSQLPlaceholders replacement count" whitelist comment for pertinent replacement count vs placeholder mismatches. Please consider carefully whether something could be a bug when you are tempted to use the whitelist comment and if so, report it.WordPress.PHP.DiscourageGoto
sniff to theWordPress-Core
ruleset.WordPress.PHP.RestrictedFunctions
sniff to theWordPress-Core
ruleset which initially forbids the use ofcreate_function()
.
This was previous only discouraged under certain circumstances.WordPress.WhiteSpace.ArbitraryParenthesesSpacing
sniff to theWordPress-Core
ruleset which checks the spacing on the inside of arbitrary parentheses.WordPress.WhiteSpace.PrecisionAlignment
sniff to theWordPress-Core
ruleset which will throw a warning when precision alignment is detected in PHP, JS and CSS files.WordPress.WhiteSpace.SemicolonSpacing
sniff to theWordPress-Core
ruleset which will throw a (fixable) error when whitespace is found before a semi-colon, except for when the semi-colon denotes an emptyfor()
condition.WordPress.CodeAnalysis.AssignmentInCondition
sniff to theWordPress-Extra
ruleset.WordPress.WP.DiscouragedConstants
sniff to theWordPress-Extra
andWordPress-VIP
rulesets to detect usage of deprecated WordPress constants, such asSTYLESHEETPATH
andHEADER_IMAGE
.- Ability to pass the
minimum_supported_version
to use for theDeprecatedFunctions
,DeprecatedClasses
andDeprecatedParameters
sniff in one go. You can pass aminimum_supported_wp_version
runtime variable for this from the command line or pass it using aconfig
directive in a custom ruleset. Generic.Formatting.MultipleStatementAlignment
- customized to have amaxPadding
of40
-,Generic.Functions.FunctionCallArgumentSpacing
andSquiz.WhiteSpace.ObjectOperatorSpacing
to theWordPress-Core
ruleset.Squiz.Scope.MethodScope
,Squiz.Scope.MemberVarScope
,Squiz.WhiteSpace.ScopeKeywordSpacing
,PSR2.Methods.MethodDeclaration
,Generic.Files.OneClassPerFile
,Generic.Files.OneInterfacePerFile
,Generic.Files.OneTraitPerFile
,PEAR.Files.IncludingFile
,Squiz.WhiteSpace.LanguageConstructSpacing
,PSR2.Namespaces.NamespaceDeclaration
to theWordPress-Extra
ruleset.- The
is_class_constant()
,is_class_property
andvalid_direct_scope()
utility methods to theWordPress\Sniff
class.
Changed
- When passing an array property via a custom ruleset to PHP_CodeSniffer, spaces around the key/value are taken as intentional and parsed as part of the array key/value. In practice, this leads to confusion and WPCS does not expect any values which could be preceded/followed by a space, so for the WordPress Coding Standard native array properties, like
customAutoEscapedFunction
,text_domain
,prefixes
, WPCS will now trim whitespace from the keys/values received before use. - The WPCS native whitelist comments used to only work when they were put on the end of the line of the code they applied to. As of now, they will also be recognized when they are be put at the end of the statement they apply to.
- The
WordPress.Arrays.ArrayDeclarationSpacing
sniff used to enforce all associative arrays to be multi-line. The handbook has been updated to only require this for multi-item associative arrays and the sniff has been updated accordingly.
The original behaviour can still be enforced by setting the newallow_single_item_single_line_associative_arrays
property tofalse
in a custom ruleset. - The
WordPress.NamingConventions.PrefixAllGlobals
sniff will now allow for a limited list of WP core hooks which are intended to be called by plugins and themes. - The
WordPress.PHP.DiscouragedFunctions
sniff used to includecreate_function
. This check has been moved to the newWordPress.PHP.RestrictedFunctions
sniff. - The
WordPress.PHP.StrictInArray
sniff now has a separate error codeFoundNonStrictFalse
for when the$strict
parameter has been set tofalse
. This allows for excluding the warnings for that particular situation, which will normally be intentional, via a custom ruleset. - The
WordPress.VIP.CronInterval
sniff now allows for customizing the minimum allowed cron interval by setting a property in a custom ruleset. - The
WordPress.VIP.RestrictedFunctions
sniff used to prohibit the use of certain WP native functions, recommending the use ofwpcom_vip_get_term_link()
,wpcom_vip_get_term_by()
andwpcom_vip_get_category_by_slug()
instead, as the WP native functions were not being cached. As the results of the relevant WP native functions are cached as of WP 4.8, the advice has now been reversed i.e. use the WP native functions instead ofwpcom...
functions. - The
WordPress.VIP.PostsPerPage
sniff now allows for customizing thepost_per_page
limit for which the sniff will trigger by setting a property in a custom ruleset. - The
WordPress.WP.I18n
sniff will now allow and actively encourage omitting the text-domain in I18n function calls if the text-domain passed via thetext_domain
property isdefault
, i.e. the domain used by Core.
Whendefault
is one of several text-domains passed via thetext_domain
property, the error thrown when the domain is missing has been downgraded to awarning
. - The
WordPress.XSS.EscapeOutput
sniff now has a separate error codeOutputNotEscapedShortEcho
and the error message texts have been updated. - Moved
Squiz.PHP.Eval
from theWordPress-Extra
andWordPress-VIP
to theWordPress-Core
ruleset. - Removed two sniffs from the
WordPress-VIP
ruleset which were already included via theWordPress-Core
ruleset. - The unit test suite is now compatible with PHPCS 3.1.0+ and PHPUnit 6.x.
- Some tidying up of the unit test case files.
- All sniffs are now also being tested against PHP 7.2 for consistent sniff results.
- An attempt is made to detect potential fixer conflicts early via a special build test.
- Various minor documentation fixes.
- Improved the Atom setup instructions in the Readme.
- Updated the unit testing information in Contributing.
- Updated the custom ruleset example for the changes contained in this release and to make it more explicit what is recommended versus example code.
- The minimum recommended version for the suggested
DealerDirect/phpcodesniffer-composer-installer
Composer plugin has gone up to0.4.3
. This patch version fixes support for PHP 5.3.
Fixed
- The
WordPress.Arrays.ArrayIndentation
sniff did not correctly handle array items with multi-line strings as a value. - The
WordPress.Arrays.ArrayIndentation
sniff did not correctly handle array items directly after an array item with a trailing comment. - The
WordPress.Classes.ClassInstantiation
sniff will now correctly handle detection when usingnew $array['key']
ornew $array[0]
. - The
WordPress.NamingConventions.PrefixAllGlobals
sniff did not allow for arbitrary word separators in hook names. - The
WordPress.NamingConventions.PrefixAllGlobals
sniff did not correctly recognize namespaced constants as prefixed. - The
WordPress.PHP.StrictInArray
sniff would erronously trigger if thetrue
for$strict
was passed in uppercase. - The
WordPress.PHP.YodaConditions
sniff could get confused over complex ternaries containing assignments. This has been remedied. - The
WordPress.WP.PreparedSQL
sniff would erronously throw errors about comments found within a DB function call. - The
WordPress.WP.PreparedSQL
sniff would erronously throw erro...
0.13.1
0.13.0
Added
- Support for PHP CodeSniffer 3.0.2+. The minimum required PHPCS version (2.9.0) stays the same.
- Support for the PHPCS 3
--ignore-annotations
command line option. If you pass this option, both PHPCS native@ignore ...
annotations as well as the WPCS specific whitelist flags will be ignored.
Changed
- The minimum required PHP version is now 5.3 when used in combination with PHPCS 2.x and PHP 5.4 when used in combination with PHPCS 3.x.
- The way the unit tests can be run is now slightly different for PHPCS 2.x versus 3.x. For more details, please refer to the updated information in the Contributing Guidelines.
- Release archives will no longer contain the unit tests and other typical development files. You can still get these by using Composer with
--prefer-source
or by checking out a git clone of the repository. - Various textual improvements to the Readme.
- Various textual improvements to the Contributing Guidelines.
- Minor internal changes.
Removed
- The
WordPress.Arrays.ArrayDeclaration
sniff has been deprecated. The last remaining checks this sniff contained have been moved to theWordPress.Arrays.ArrayDeclarationSpacing
sniff. - Work-arounds which were in place to support PHP 5.2.
Fixed
- A minor bug where the auto-fixer could accidentally remove a comment near an array opener.
0.12.0
Added
- A default file encoding setting to the
WordPress-Core
ruleset. All files sniffed will now be regarded asutf-8
by default. WordPress.Arrays.ArrayIndentation
sniff to theWordPress-Core
ruleset to verify - and auto-fix - the indentation of array items and the array closer for multi-line arrays. This replaces the (partial) indentation fixing contained within theWordPress.Array.ArrayDeclarationSpacing
sniff.WordPress.Arrays.CommaAfterArrayItem
sniff to theWordPress-Core
ruleset to enforce that each array item is followed by a comma - except for the last item in a single-line array - and checks the spacing around the comma. This replaces (and improves) the checks which were previously included in theWordPress.Arrays.ArrayDeclaration
sniff which were causing incorrect fixes and fixer conflicts.WordPress.Functions.FunctionCallSignatureNoParams
sniff to theWordPress-Core
ruleset to verify that function calls without parameters do not have any whitespace between the parentheses.WordPress.WhiteSpace.DisallowInlineTabs
to theWordPress-Core
ruleset to verify - and auto-fix - that spaces are used for mid-line alignment.WordPress.WP.CapitalPDangit
sniff to theWordPress-Core
ruleset to - where relevant - verify thatWordPress
is spelled correctly. For misspellings in text strings and comment text, the sniff can auto-fix violations.Squiz.Classes.SelfMemberReference
whitespace related checks to theWordPress-Core
ruleset and the additional check for usingself
rather than a FQN to theWordPress-Extra
ruleset.Squiz.PHP.EmbeddedPhp
sniff to theWordPress-Core
ruleset to check PHP code embedded within HTML blocks.PSR2.ControlStructures.SwitchDeclaration
to theWordPress-Core
ruleset to check for the correct layout ofswitch
control structures.WordPress.Classes.ClassInstantion
sniff to theWordPress-Extra
ruleset to detect - and auto-fix - missing parentheses on object instantiation and superfluous whitespace in PHP and JS files. The sniff will also detectnew
being assigned by reference.WordPress.CodeAnalysis.EmptyStatement
sniff to theWordPress-Extra
ruleset to detect - and auto-fix - superfluous semi-colons and empty PHP open-close tag combinations.WordPress.NamingConventions.PrefixAllGlobals
sniff to theWordPress-Extra
ruleset to verify that all functions, classes, interfaces, traits, variables, constants and hook names which are declared/defined in the global namespace are prefixed with one of the prefixes provided via a custom property or via the command line.
To activate this sniff, one or more allowed prefixes should be provided to the sniff. This can be done using a custom ruleset or via the command line.
PHP superglobals and WP global variables are exempt from variable name prefixing. Deprecated hook names will also be disregarded when non-prefixed. Back-fills for known native PHP functionality is also accounted for.
For verified exceptions, unprefixed code can be whitelisted.
Code in unit test files is automatically exempt from this sniff.WordPress.WP.DeprecatedClasses
sniff to theWordPress-Extra
ruleset to detect usage of deprecated WordPress classes.WordPress.WP.DeprecatedParameters
sniff to theWordPress-Extra
ruleset to detect deprecated parameters being passed to WordPress functions with a value other than the expected default.- The
sanitize_textarea_field()
function to thesanitizingFunctions
list used by theWordPress.CSRF.NonceVerification
,WordPress.VIP.ValidatedSanitizedInput
andWordPress.XSS.EscapeOutput
sniffs. - The
find_array_open_closer()
utility method to theWordPress_Sniff
class. - Information about setting
installed_paths
using a custom ruleset to the Readme. - Additional support links to the
composer.json
file. - Support for Composer PHPCS plugins which sort out the
installed_paths
setting. - Linting and code-style check of the XML ruleset files provided by WPCS.
Changed
- The minimum required PHP_CodeSniffer version to 2.9.0 (was 2.8.1). Take note: PHPCS 3.x is not (yet) supported. The next release is expected to fix that.
- Improved support for detecting issues in code using heredoc and/or nowdoc syntax.
- Improved sniff efficiency, precision and performance for a number of sniffs.
- Updated a few sniffs to take advantage of new features and fixes which are included in PHP_CodeSniffer 2.9.0.
WordPress.Files.Filename
: The "file name mirrors the class name prefixed with 'class'" check for PHP files containing a class will no longer be applied to typical unit test classes, i.e. for classes which extendWP_UnitTestCase
,PHPUnit_Framework_TestCase
andPHPUnit\Framework\TestCase
. Additional test case base classes can be passed to the sniff using the newcustom_test_class_whitelist
property.- The
WordPress.Files.FileName
sniff allows now for more theme-specific template hierarchy based file name exceptions. - The whitelist flag for the
WordPress.VIP.SlowQuery
sniff wastax_query
which was unintuitive. This has now been changed toslow query
to be in line with other whitelist flags. - The
WordPress.WhiteSpace.OperatorSpacing
sniff will now ignore operator spacing withindeclare()
statements. - The
WordPress.WhiteSpace.OperatorSpacing
sniff now extends the upstreamSquiz.WhiteSpace.OperatorSpacing
sniff for improved results and will now also examine the spacing around ternary operators and logical (&&
,||
) operators. - The
WordPress.WP.DeprecatedFunctions
sniff will now detect functions deprecated in WP 4.7 and 4.8. Additionally, a number of other deprecated functions which were previously not being detected have been added to the sniff and for a number of functions the "alternative" for the deprecated function has been added/improved. - The
WordPress.XSS.EscapeOutput
sniff will now also detect unescaped output when the short open echo tags<?=
are used. - Updated the list of WP globals which is used by both the
WordPress.Variables.GlobalVariables
and theWordPress.NamingConventions.PrefixAllGlobals
sniffs. - Updated the information on using a custom ruleset and associated naming conventions in the Readme.
- Updated the custom ruleset example to provide a better starting point and renamed the file to follow current PHPCS best practices.
- Various inline documentation improvements.
- Updated the link to the PHPStorm documentation in the Readme.
- Various textual improvements to the Readme.
- Minor improvements to the build script.
Removed
Squiz.Commenting.LongConditionClosingComment
sniff from theWordPress-Core
ruleset. This rule has been removed from the WP Coding Standards handbook.- The exclusion of the
Squiz.ControlStructures.ControlSignature.NewlineAfterOpenBrace
error from theWordPress-Core
ruleset. - The exclusion of the
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
andPEAR.Functions.FunctionCallSignature.CloseBracketLine
error from theWordPress-Core
ruleset when used in combination with the fixer, i.e.phpcbf
. The exclusions remain in place forphpcs
runs. wp_get_post_terms()
,wp_get_post_categories()
,wp_get_post_tags()
andwp_get_object_terms()
from theWordPress.VIP.RestrictedFunctions
sniff as these functions are now cached natively since WP 4.7.
Fixed
- The
WordPress.Array.ArrayDeclarationSpacing
could be overeager when fixing associative arrays to be multi-line. Non-associative single-line arrays which contained a nested associative array would also be auto-fixed by the sniff, while only the nested associated array should be fixed. - The
WordPress.Files.FileName
sniff did not play nice with IDEs passing a filename to PHPCS via--stdin-path=
. - The
WordPress.Files.FileName
sniff was being triggered on code passed viastdin
where there is no file name to examine. - The
WordPress.PHP.YodaConditions
sniff would give a false positive for the result of a condition being assigned to a variable. - The
WordPress.VIP.RestrictedVariables
sniff was potentially underreporting issues when the variables being restricted were a combination of variables, object properties and array members. - The auto-fixer in the
WordPress.WhiteSpace.ControlStructureSpacing
sniff which deals with "blank line after control structure" issues could cause comments at the end of control structures to be removed. - The
WordPress.WP.DeprecatedFunctions
sniff was reporting the wrong WP version for the deprecation of a number of functions. - The
WordPress.WP.EnqueuedResources
sniff would potentially underreport issues in certain circumstances. - The
WordPress.XSS.EscapeOutput
sniff will no now longer report issues when it encounters a__DIR__
,(unset)
cast or a floating point number, and will correctly disregard more arithmetic operators when deciding whether to report an issue or not. - The whitelisting of errors using flags was sometimes a bit too eager and could accidentally whitelist code which was not intended to be whitelisted.
- Various (potential)
Undefined variable
,Undefined index
andUndefined offset
notices. - Grammer in one of the `WordPres...
0.11.0
Important notes for end-users:
If you use the WordPress Coding Standards with a custom ruleset, please be aware that some of the checks have been moved between sniffs and that the naming of a number of error codes has changed.
If you exclude some sniffs or error codes, you may have to update your custom ruleset to be compatible with WPCS 0.11.0.
Additionally, to make it easier for you to customize your ruleset, two new wiki pages have been published with information on the properties you can adjust from your ruleset:
For more detailed information about the changed sniff names and error codes, please refer to PR #633 and PR #814.
Important notes for sniff developers:
If you maintain or develop sniffs based upon the WordPress Coding Standards, most notably, if you use methods and properties from the WordPress_Sniff
class, extend one of the abstract sniff classes WPCS provides or extend other sniffs from WPCS to use their properties, please be aware that this release contains significant changes which will, more likely than not, affect your sniffs.
Please read this changelog carefully to understand how this will affect you.
For more detailed information on the most significant changes, please refer to PR #795, PR #833 and PR #841.
You are also encouraged to check the file history of any WPCS classes you extend.
Added
WordPress.WP.DeprecatedFunctions
sniff to theWordPress-Extra
ruleset to check for usage of deprecated WP version and show errors/warnings depending on aminimum_supported_version
which can be passed to the sniff from a custom ruleset. The default value for theminimum_supported_version
property is three versions before the current WP version.WordPress.WP.I18n
: ability to check for missing translators comments when a I18n function call contains translatable text strings containing placeholders. This check will also verify that the translators comment is correctly placed in the code and uses the correct comment type for optimal compatibility with the various tools available to create.pot
files.WordPress.WP.I18n
: ability to pass thetext_domain
to check for from the command line.WordPress.Arrays.ArrayDeclarationSpacing
: check + fixer for single line associative arrays. The handbook states that these should always be multi-line.WordPress.Files.FileName
: verification that files containing a class reflect this in the file name as per the core guidelines. This particular check can be disabled in a custom ruleset by setting the newstrict_class_file_names
property.WordPress.Files.FileName
: verification that files in/wp-includes/
containing template tags - annotated with@subpackage Template
in the file header - use the-template
suffix.WordPress.Files.FileName
:is_theme
property which can be set in a custom ruleset. This property can be used to indicate that the project being checked is a theme and will allow for a predefined theme hierarchy based set of exceptions to the file name rules.WordPress.VIP.AdminBarRemoval
: check for hiding the admin bar using CSS.WordPress.VIP.AdminBarRemoval
: customizableremove_only
property to toggle whether to error of all manipulation of the visibility of the admin bar or to execute more thorough checking for removal only.WordPress.WhiteSpace.ControlStructureSpacing
: support for checking the whitespace intry
/catch
constructs.WordPress.WhiteSpace.ControlStructureSpacing
: check that the space after the open parenthesis and before the closing parenthesis of control structures and functions is exactly one space. Includes auto-fixer.WordPress.WhiteSpace.CastStructureSpacing
: ability to automatically fix errors thrown by the sniff.WordPress.VIP.SessionFunctionsUsage
: detection of thesession_abort()
,session_create_id()
,session_gc()
andsession_reset()
functions.WordPress.CSRF.NonceVerification
: ability to pass custom sanitization functions to the sniff.- The
get_the_ID()
function to theautoEscapedFunctions
list used by theWordPress.XSS.EscapeOutput
sniff. - The
wp_strip_all_tags()
,sanitize_hex_color_no_hash()
andsanitize_hex_color()
functions to thesanitizingFunctions
list used by theWordPress.CSRF.NonceVerification
,WordPress.VIP.ValidatedSanitizedInput
andWordPress.XSS.EscapeOutput
sniffs. - The
floatval()
function to theescapingFunctions
,sanitizingFunctions
,unslashingSanitizingFunctions
,SQLEscapingFunctions
lists used by theWordPress.CSRF.NonceVerification
,WordPress.VIP.ValidatedSanitizedInput
,WordPress.XSS.EscapeOutput
andWordPress.WP.PreparedSQL
sniffs. - The table name based
clean_*_cache()
functions to thecacheDeleteFunctions
list used by theWordPress.VIP.DirectDatabaseQuery
sniff. - Abstract
AbstractFunctionParameter
parent class to allow for examining parameters passed in function calls. - A number of utility functions to the
WordPress_Sniff
class:strip_quotes()
,addMessage()
,addFixableMessage()
,string_to_errorcode()
,does_function_call_have_parameters()
,get_function_call_parameter_count()
,get_function_call_parameters()
,get_function_call_parameter()
,has_html_open_tag()
. Squiz.Commenting.LongConditionClosingComment
,Squiz.WhiteSpace.CastSpacing
,Generic.Formatting.DisallowMultipleStatements
to theWordPress-Core
ruleset.Squiz.PHP.NonExecutableCode
,Squiz.Operators.IncrementDecrementUsage
,Squiz.Operators.ValidLogicalOperators
,Squiz.Functions.FunctionDuplicateArgument
,Generic.PHP.BacktickOperator
,Squiz.PHP.DisallowSizeFunctionsInLoops
to theWordPress-Extra
ruleset.- Numerous additional unit tests covering the correct handling of properties overruled via a custom ruleset by various sniffs.
- Instructions on how to use WPCS with Visual Studio to the Readme.
- Section on how to use WPCS with CI Tools to the Readme, initially covering integration with Travis CI.
- Section on considerations when writing sniffs for WPCS to
Contributing.md
.
Changed
- The minimum required PHP version to 5.2 (was 5.1).
- The minimum required PHP_CodeSniffer version to 2.8.1 (was 2.6).
- Improved support for detecting issues in code using closures (anonymous functions), short array syntax and anonymous classes.
- Improved sniff efficiency and performance for a number of sniffs.
- The discouraged/restricted functions sniffs have been reorganized and made more modular.
- The new
WordPress.PHP.DevelopmentFunctions
sniff now contains the checks related to PHP functions typically used during development which are discouraged in production code. - The new
WordPress.PHP.DiscouragedPHPFunctions
sniff now contains checks related to various PHP functions, use of which is discouraged for various reasons. - The new
WordPress.WP.AlternativeFunctions
sniff contains the checks related to PHP functions for which WP offers an alternative which should be used instead. - The new
WordPress.WP.DiscouragedFunctions
sniff contains checks related to various WP functions, use of which is discouraged for various reasons. - A number of checks contained in the
WordPress.VIP.RestrictedFunctions
sniff have been moved to other sniffs. - The
WordPress.PHP.DiscouragedFunctions
sniff has been deprecated and is no longer used. The checks which were previously contained herein have been moved to other sniffs. - The reorganized sniffs also detect a number of additional functions which were previously ignored by these sniffs. For more detail, please refer to the summary of the PR and to PR #759.
- The new
- The error codes for these sniffs as well as for
WordPress.DB.RestrictedClasses
,WordPress.DB.RestrictedFunctions
,WordPress.Functions.DontExtract
,WordPress.PHP.POSIXFunctions
and a number of theVIP
sniffs have changed. They were previously based on function group names and will now be based on function group name in combination with the identified function name. Complete function groups can still ...