Skip to content

Conversation

mikachan
Copy link
Member

Quick PR to add missing spaces to some of the form labels. It looks like some were accidentally removed in #165.

@mikachan mikachan self-assigned this Jan 25, 2023
Copy link
Contributor

@matiasbenedetto matiasbenedetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be better to provide context to the translators with the use of _x() instead of __() and the code comment for translators? It seems like _x() was created for that: https://developer.wordpress.org/reference/functions/_x/

@mikachan
Copy link
Member Author

Could it be better to provide context to the translators with the use of _x() instead of __() and the code comment for translators? It seems like _x() was created for that:

Yeah, _x() may work better for all these translations. Maybe it would be better to update all translations using this function in a separate PR?

@matiasbenedetto
Copy link
Contributor

matiasbenedetto commented Jan 26, 2023

Could it be better to provide context to the translators with the use of _x() instead of __() and the code comment for translators? It seems like _x() was created for that:

Yeah, _x() may work better for all these translations. Maybe it would be better to update all translations using this function in a separate PR?

Sounds good!

@matiasbenedetto matiasbenedetto merged commit 4e1cb55 into trunk Jan 26, 2023
@mikachan mikachan deleted the fix/option-spaces branch January 26, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants