Skip to content

Avoid adding Template info to style.css if it's empty #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 27, 2023
Merged

Avoid adding Template info to style.css if it's empty #315

merged 7 commits into from
Apr 27, 2023

Conversation

matiasbenedetto
Copy link
Contributor

Avoid adding Template info to style.css if it's empty

Fixes: #314

madhusudhand
madhusudhand reviewed Apr 13, 2023
View reviewed changes
Copy link
Member

@madhusudhand madhusudhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it is preserved in create blank theme option (create blank theme -> activate -> export)

@matiasbenedetto
Copy link
Contributor Author

Thanks for testing! The new line should is now avoided after the latest commit.

jffng
jffng reviewed Apr 14, 2023
View reviewed changes
matiasbenedetto and others added 2 commits April 17, 2023 13:00
@matiasbenedetto @jffng
Adding extra line break
45ce6e4 
Co-authored-by: Jeff Ong <jonger4@gmail.com>
@matiasbenedetto
Merge branch 'trunk' into fix/314
26f7e2e
@matiasbenedetto matiasbenedetto requested a review from jffng April 17, 2023 18:37
jffng
jffng reviewed Apr 19, 2023
View reviewed changes
Copy link
Contributor

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now working as advertised, but why is the diff so large with fallback-fonts-list.json?

mikachan
mikachan approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the changes to fallback-fonts-list.json should just be removed from this PR, but otherwise this looks good to bring in.

@matiasbenedetto
Copy link
Contributor Author

Thanks for taking a look!

Looks like the changes to fallback-fonts-list.json should just be removed from this PR

That was solved by merging with the latest trunk version.

@matiasbenedetto matiasbenedetto merged commit 3377038 into trunk Apr 27, 2023
@vcanales vcanales deleted the fix/314 branch May 23, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhusudhand madhusudhand madhusudhand left review comments

@jffng jffng jffng left review comments

@mikachan mikachan mikachan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template: in style.css header of parent theme
4 participants
@matiasbenedetto @mikachan @madhusudhand @jffng