Fix export theme from Site Editor #338
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related. #294 (comment)
I've been looking into why the Export function is broken on the site editor, and the problem is two-fold.
First, this error was thrown:
This happens because when hitting the endpoint, theme-zip.php is not within the admin context, so wp-admin/includes.php is never included, and
download_url
never defined.It can be solved by modifying
add_media_to_zip
to import wp-admin/includes/admin.php when needed, although we might want to add that somewhere up the chain in case other admin functions are made available through the REST API.Second,
uri
has a different name in the frontend app —theme_uri
— andtags_custom
is absent.