Skip to content

Prevent additional white space in font credits in readme.txt #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2023
Merged

Prevent additional white space in font credits in readme.txt #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion admin/class-manage-fonts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,12 +355,16 @@ function manage_font_license( $font_name, $file_name ) {

// Build the font credits string
$font_credits = "

{$font_name} Font
{$copyright} {$license_info} {$license_url} {$font_source}
{$end_credits_note}
";

// Check if readme.txt ends with a new line
if ( "\n" !== $readme_file_contents[ strlen( $readme_file_contents ) - 1 ] ) {
$font_credits = "\n" . $font_credits;
}

// Add font credits to the end of readme.txt
file_put_contents(
$readme_file,
Expand Down