Avoid white spaces or other weird characters on font asset paths. #401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ?
If you upload a font with spaces in any of the components that end up in the file name of the font asset the resulting font URL has a space and that causes problems.
For example: if you upload a variable font with a font weight of "100 900", the resulting font path in theme.json would be
font-name_normal_100 900.ttf
and that can be problematic.With this change, we would have
font-name_normal_100-900.ttf
.How to test: