Fix: react render warning #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S. You will need to set |
mikachan
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information, see the following issue in the Gutenberg project:
WordPress/gutenberg#49308
In WordPress 6.2, React version has been updated from 17 to 18. This causes a warning error to appear in the browser console when using the
renderfunction.In order to get rid of this warning error, we need to do compatible processing regardless of whether you are using React version 17 or 18.
The PR check for the presence of
createRoot, which is recommended from React 18, as suggested in this comment, and if it is present, usecreateRootinstead ofrender.