Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Inserter can insert in wrong place depending on block selection and focus #24262

Closed
glendaviesnz opened this issue Jul 29, 2020 · 1 comment · Fixed by #24285
Closed
Assignees
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended

Comments

@glendaviesnz
Copy link
Contributor

Describe the bug

Clicking the inline inserter doesn't by default move the cursor to that spot in the document. This means that if you use the 'Browse all' option in the block list the new block may end up in the last place in the document that had focus instead of the position of the clicked inline inserter

To reproduce
Steps to reproduce the behavior:

  1. Open a new page and add column block with some content in each column
  2. Add some paragraph blocks under the columns
  3. While cursor is still in bottom paragraph click on the inline inserter in the column and use 'browse all' to select a block
  4. The block will be inserted at the bottom instead of in the column
  5. Click in the column again and make sure cursor is next to the inline insert and select another block via 'browse all'
  6. This time it should be inserted in the column

Expected behavior
Clicking the inline inserter should move the focus to that point so that using browse all will know the location for inserting new block.

Screenshots
browse-all

Editor version (please complete the following information):
Happens on 8.5.1 and 8.6.1

@glendaviesnz glendaviesnz added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended labels Jul 29, 2020
@sirreal
Copy link
Member

sirreal commented Jul 29, 2020

I've just confirmed this is an issue in 5.5-RC1-48681 without the Gutenberg plugin installed.

@mcsf mcsf changed the title Inline Inserter Inline Inserter can insert in wrong place depending on block selection and focus Jul 29, 2020
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 30, 2020
@ntsekouras ntsekouras removed the [Status] In Progress Tracking issues with work in progress label Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants