Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks in Customizer: Block toolbar positioning #25201

Closed
mapk opened this issue Sep 9, 2020 · 5 comments
Closed

Blocks in Customizer: Block toolbar positioning #25201

mapk opened this issue Sep 9, 2020 · 5 comments
Assignees
Labels
Customization Issues related to Phase 2: Customization efforts [Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Accessibility Feedback Need input from accessibility Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress

Comments

@mapk
Copy link
Contributor

mapk commented Sep 9, 2020

Current problem

Blocks in the Customizer show the block toolbar still attached to the block itself. This causes some difficulty selecting items in the toolbar that are beyond the width of the Customizer.

Screen Shot 2020-09-09 at 12 53 06 PM

Proposed solution

In the past, I've suggested that we use the mobile web view in the Customizer – the block toolbar should stick to the top. I'm still promoting this here, but @draganescu pointed out the Customizer is narrower than most phones. This means we'll need to accommodate this narrow width when we have long block toolbars.

Mockup
Screen Shot 2020-09-09 at 1 18 16 PM

Prototype
scroll

@mapk mapk added Customization Issues related to Phase 2: Customization efforts Needs Design Feedback Needs general design feedback. [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels Sep 9, 2020
@mapk mapk added this to the WordPress 5.6 milestone Sep 9, 2020
@mapk mapk self-assigned this Sep 9, 2020
@paaljoachim
Copy link
Contributor

As I began reading the issue my first thought was to add as you mentioned a sticky toolbar (similar to mobile).
Showing parts of the last icon gives a hint that there is more to be seen, that one will need to use the keyboard to move to the right/left, or the cursor and move the toolbar.

Another thought that come up is.... what if we split the toolbar in two parts. Having a top and bottom sticky toolbar.
The following does not look nice but it is meant as a visual idea.

2-row-toolbar

Another idea.... well this is supplementary, would be to make the Customizer sidebar resizable, so the user can make the area wider and be able to see the full toolbar.

I'll add on to this comment when/if other ideas come up.

@annezazu
Copy link
Contributor

In light of closing out #25155 I want to note that in designing this next version for the toolbar, it's necessary to think about the "three dot" menu option as right now that opens as a transparent menu.

@draganescu draganescu assigned kevin940726 and unassigned mapk Sep 24, 2020
@draganescu
Copy link
Contributor

Apparently this has been fixed recently as now in master the toolbar is fixed to top but:

  • it scrolls with the sidebar and it's supposed to stick to the top
  • on desktop at least, one can't scroll it to see all the buttons

@adamziel
Copy link
Contributor

Blocked by #25625

@noisysocks
Copy link
Member

Closing this as we will be completely rearchitecting our implementation of how blocks work in the Customiser. Also worth noting that this specific design detail came up in #26900.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customization Issues related to Phase 2: Customization efforts [Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Accessibility Feedback Need input from accessibility Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants