-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global Styles: Add alignment support in global typography styles #48202
Comments
I can start investigating this issue next week 👌 |
A couple of notes on justified text:
In that light, here's a way way obsolete mockup of justified text in a global interface: The icons, colors, all of the above are off, so do not take this as a design. Purely as an example of one way this interface might be put together. |
Would this be also a good place for adding controls for |
Potentially. I haven't used that one very much. |
Hi folks, thank you for working on this. Just making a note that this was requested in forums here: https://wordpress.org/support/topic/space-between-header-and-body-on-pages-drives-me-crazy/#post-16789630 |
Baby, I just want to add that I miss very very very much the Justify alignment. OMG. I understand the necessary precaution... Because of it, you guys could plan the necessary implementation steps. It seems that there are more than one issues involved. I was so happy when I saw |
I unassigned me from this issue since we won't focus on this in the short time. |
Related issues/PRs: |
Seems fine to do that. Figma if you want to tinker. |
I added an alternate to the Figma. What do you think? Based on #59531. |
Looks good! Whether it's the row of 4 icons or a vertical stack with labels, I've less of a strong opinion on, happy to defer. What I'd deem important is to show the yellow notice below the justified text option when selected, I'm assuming that's still present? |
Sure, I had missed that. |
If all four of However, the original design only allows two types at the root level: Which options should be allowed? |
Good point to clarify. I omitted center from the original designs because it seems borderline useless as a default layout for text, arguably even less legible than justified text. Though I suppose if it substantially eases implementation, and if the center option would carry a similar legibility warning as justified does, perhaps it might be fine, so as to unstick this? |
I say we include them all, even without legibility notices. Sure, it may not be ideal, but I can see it working in some cases. And I'm hesitant to have some controls available in some places, while not in others. |
Thanks for the feedback! As suggested in #60762, I am thinking of adding the text alignment UI at the block level first. If it ships successfully, I would like to come back to this issue. |
I would not omit the legibility notice, at least from the justified text one. It's a very common question why WordPress doesn't support justified text in the text alignment dropdown, and showing the legibility notice in context of the global control would provide the answer right there. |
Before we land #48146, we'd like to first support alignment in global typography styles. Alignment support can include justification, as long as it also supports hyphenation.
To properly handle hyphenation, we'll need
lang
support on the block level at least, too: #15349Related #27300, #8450
Done is:
The text was updated successfully, but these errors were encountered: