-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Editor: Add 'Justify' option to alignment controls #48146
Conversation
Size Change: +83 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me this looks good. Would be good if someone signed off on the icon addition.
Are there any open issues that can be closed with this? |
Also would be great if a global style option could be added, not sure how hard that would be. |
Flaky tests detected in 654cf3e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4198085888
|
@ellatrix I think it's just #27300 and #8450
I don't see text alignment as a global style... Do you mean "it would be great to add text alignment as a global style" generally? |
Punting on this PR initially in favor of #48202 |
What?
Adds a 'Align text justify' option to alignment controls:
Why?
'Justify' as a text alignment option is a long-requested Gutenberg enhancement: #8450
Many plugins have added 'Justify' on their own but it's much better for Gutenberg to simply support it.
Fixes #27300
Fixes #8450
How?
This PR registers a new 'Align text justify' option alongside the existing alignment options.
Testing Instructions
Testing Instructions for Keyboard
N/A