Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose theme_supports data through a minimial theme controller #10518

Merged
merged 18 commits into from
Oct 15, 2018
Merged

Expose theme_supports data through a minimial theme controller #10518

merged 18 commits into from
Oct 15, 2018

Commits on Oct 10, 2018

  1. First pass at adding a Themes endpoint for the current active theme.

    @desrosj
    desrosj committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    049f30f View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2018

  1. Don't return false when the theme does not support thumbnails. Only… 

    … list view context on formats and post-thumbnails fields. Uncomment permissions logic. Remove old code placing this data in the index.
    @desrosj
    desrosj committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    9187617 View commit details
    Browse the repository at this point in the history

  2. Use the new active theme endpoint for determining theme support.

    @desrosj
    desrosj committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    e013653 View commit details
    Browse the repository at this point in the history

  3. Add unit tests for the new active theme controller.

    @desrosj
    desrosj committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    08eb03d View commit details
    Browse the repository at this point in the history

  4. Pre-load the active theme endpoint.

    @desrosj
    desrosj committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    5b5675d View commit details
    Browse the repository at this point in the history

  5. PR Review Feedback adjustments: 

    - Alignment fixes
- Add missing textdomain arguments
- Update the property contexts to edit (should be the context the data is accessed)
- Add missing description for `post-thumbnails`
- Link should be `self`, not `active`
    @desrosj
    desrosj committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    3af33f2 View commit details
    Browse the repository at this point in the history

  6. Fix failing tests. Change default context to edit.

    @desrosj
    desrosj committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    f18a663 View commit details
    Browse the repository at this point in the history

  7. Add missing textdomain.

    @desrosj
    desrosj committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    7a1c75e View commit details
    Browse the repository at this point in the history

  8. Remove contexts from themes (see https://wordpress.slack.com/archives… 

    …/C02RQC26G/p1539297122000100).
    @desrosj
    desrosj committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    06fb8cf View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' of github.com:WordPress/gutenberg into add/core… 

    …-rest-api-themes-controller

# Conflicts:
#	lib/load.php
    @desrosj
    desrosj committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    2ff2fb4 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2018

  1. Always include post-thumbnails property to ensure consistent respon… 

    …ses.
    @desrosj
    desrosj committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    2bbd6ba View commit details
    Browse the repository at this point in the history

  2. Avoid using the __get() magic method.

    @desrosj
    desrosj committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    f593169 View commit details
    Browse the repository at this point in the history

  3. Change the themes/active route to themes?status=active. The forme… 

    …r would cause future issues when `themes/themename` returns data for a specific theme.

For now, limit the `status` param to one value, `active`, by specifying the param as an `enum`.

Also, remove field not 100% required for Gutenberg (name, version, template, etc.).
    @desrosj
    desrosj committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    6e8abc1 View commit details
    Browse the repository at this point in the history

  4. Change variable name from currentTheme to activeThemes, as the en… 

    …dpoint now returns a collection.
    @desrosj
    desrosj committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    c972f4a View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2018

  1. Remove _links from the response and adjust the theme supports prope… 

    …rty description.
    @desrosj
    desrosj committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    d3dbb6f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:WordPress/gutenberg into add/core… 

    …-rest-api-themes-controller
    @desrosj
    desrosj committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    9693640 View commit details
    Browse the repository at this point in the history

  3. Updating JavaScript documentation.

    @desrosj
    desrosj committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    b1fe1b7 View commit details
    Browse the repository at this point in the history

  4. Rename TotalThemes to TotalPages

    @danielbachhuber
    danielbachhuber committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    f7cd0a5 View commit details
    Browse the repository at this point in the history