Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix: make meta+A behaviour of selecting all blocks work on safari and firefox #8180
On safari and firefox isEntirelySelected( target ) called right after meta+A event is fired when meta key is not released in the middle returns false but the content gets selected anyway.
How has this been tested?
I added some paragraphs.
referenced this pull request
Jul 25, 2018
Aug 1, 2018
I've tested this in Chrome, Firefox, Safari, Edge, and IE 11 and the bug is fixed
Might be good to get another pair of eyes on this since I'm not 100% on how it works.
Hi @aduth, @noisysocks I checked that in fact, we could simplify the logic to what @noisysocks said.