Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an extension slot for inserter menu. #17183

Closed
wants to merge 1 commit into from

Conversation

ck-lee
Copy link
Contributor

@ck-lee ck-lee commented Aug 26, 2019

Description

Added an extension slot for inserter menu.
When the slot is filled, the empty state (isMenuEmpty is true) should be handle by the fills.
When the slot is not filled, the empty state behaves the same as before. It shows "No blocks found".

How has this been tested?

Tested locally

Types of changes

New feature (non-breaking change which adds functionality)
This PR is a split of #16524

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

When the `slot` is filled, the empty state (isMenuEmpty is true) should be handle by the `fills`.
When the `slot` is not filled, the empty state behaves the same as before. It shows "No blocks found".
@talldan talldan added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Enhancement A suggestion for improvement. [Feature] Block Directory Related to the Block Directory, a repository of block plugins labels Aug 26, 2019
@noisysocks
Copy link
Member

Closing in favour of #17431.

@noisysocks noisysocks closed this Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Directory Related to the Block Directory, a repository of block plugins [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants