-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monorepo] Import gutenberg-mobile as new WordPress react-native packages #17456
Conversation
I love it ❤️ How can I help to merge it? Will we have to split it into more PRs? Do you need my review now or is it mostly an experiment? |
I'm thinking test and report bugs and other problems! Also there is going to be a lot of work needed around integrating the new packages with the current ones in terms of scripts, build, lint checks, doc gen, package release... obviously we cannot do everything at once but I expect this PR not to break anything either on the web or the mobile side.
I'd like to but I'm not sure how at this point, most added files depend on each others at the moment... ideas are welcomed here 👍
It's mostly an experiment at this point, but hopefully it could turn into a real proposal! |
2d153a6
to
515c9c1
Compare
515c9c1
to
2bf7561
Compare
Let's close in favor of #17950 which is more up to date. It looks like it follows the same approach. |
Description
Explores #11491.
This is an experiment to add gutenberg-mobile build and tools to gutenberg.
New packages added:
@wordpress/react-native-gutenberg-editor
@wordpress/react-native-gutenberg-bridge
@wordpress/react-native-aztec
@wordpress/react-native-e2e-tests
Usual
yarn
commands ran fromgutenberg-mobile
are now accessible fromgutenberg
usingnpm run native ...
.For instance:
yarn start
=>npm run native start
bundle
however, has been replaced withbuild
to follow gutenberg naming conventionsyarn bundle:android
=>npm run native build
Some commands that are out of date have been removed (makepot...)
This is still a work in progress. Currently, the demo app does not work as
master
is broken on native (see #17228 for a fix), native tests are failing withTypeError: r.editor is not a function
inpackages/edit-post/src/test/editor.native.js
, and many things remain untested.How has this been tested?
TBD.
npm install
npm run native start:reset
andnpm run native android
npm run build
...
Types of changes
Add new native packages, for native build, unifying the 2 repositories
Checklist:
package-lock.json
are OKgutenberg-mobile
develop branchgradle-wrapper.jar
committed to the repo though and we might want to fix that later?)