Writing flow: allow paste on multiple selected blocks #18746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Feature] Block Multi Selection
ellatrix
requested review from
daniloercoli,
etoledom,
jorgefilipecosta,
SergioEstevao,
talldan and
youknowriad
as code owners
ellatrix
added
the
[Feature] Writing Flow
ellatrix
requested review from
ajitbohra,
gziolo,
nerrad and
ntwb
as code owners
ellatrix
changed the title
ellatrix
force-pushed
the
try/multi-select-paste
branch
from
9b9edcd
to
515f377
Compare
ellatrix
force-pushed
the
try/multi-select-paste
branch
from
515f377
to
874720f
Compare
ellatrix
force-pushed
the
try/multi-select-paste
branch
from
874720f
to
1879822
Compare
mcsf
approved these changes
Dec 6, 2019
| // behaviour. | ||
| return; | ||
| } | ||
| } |
There was a problem hiding this comment.
This is a super thorough block in terms of browser support :), what did you base it on?
There was a problem hiding this comment.
Some of this is actually a copy from rich text. :) We'll need to find a way to allow this function to be reused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17931.
Currently pasting on multiple selected blocks is buggy. It will leave the selected blocks and split one of them, pasting the content between the split pieces. This is because
RichTextis handling paste. Instead, the block editor should handle paste.Adds e2e tests. Until now we did not have any e2e test for cut/copy/paste.
How has this been tested?
Select multiple blocks and paste.
Select a single block without putting focus somewhere and paste.
Screenshots
Types of changes
Bug fix
Checklist: