Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote Attempt Block Recovery as primary action on block invalidation warning #19449

Closed
wants to merge 1 commit into from

Conversation

gwwar
Copy link
Contributor

@gwwar gwwar commented Jan 6, 2020

Part of #7604

Screen Shot 2020-01-06 at 4 31 27 PM

Proposed changes here are to:

  1. Move "Attempt Block Recovery" as primary action. We're in the block-editor, so why not favor the block attributes in recovery?
  2. Move Convert to HTML down to the more menu as an advanced option.
  3. (Not implemented yet) Under "Resolve", provide clearer options. Keep as HTML, prefer HTML to convert to Blocks, or prefer Block Attributes.

I think displaying the edit view might be more useful (as folks are usually confused by the HTML block interface). If we want to display markup, we should show the full block markup including comment attributes. Otherwise it turns into a "why???" pretty easily when there's no difference in markup or visual changes:

Screen Shot 2020-01-06 at 4 30 11 PM

^^ The Resolve Modal for a heading tag where markup doesn't match the block attribute, H2 vs H3.

<!-- wp:heading {"level":3} -->
<h2>Hello World</h2>
<!-- /wp:heading -->

I'm open to early copy feedback (this is pretty awkward to describe to folks) as well as feedback on shuffling around options.

cc @apeatling @aduth

@gwwar gwwar added the [Status] In Progress Tracking issues with work in progress label Jan 6, 2020
@gwwar gwwar self-assigned this Jan 6, 2020
@gwwar
Copy link
Contributor Author

gwwar commented Mar 27, 2020

I might pick this up again later, but closing out for now

@gwwar gwwar closed this Mar 27, 2020
@aristath aristath deleted the update/block-invalidation-cta branch November 10, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant